Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NV-1959B - 🐛 Bug Report: The Notification Center isn't mobile responsive #3948

Merged
merged 4 commits into from
Aug 30, 2023
Merged

NV-1959B - 🐛 Bug Report: The Notification Center isn't mobile responsive #3948

merged 4 commits into from
Aug 30, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Aug 10, 2023

What change does this PR introduce?

Fix the notification popup which would overflow to one side on mobile screens.

Why was this change needed?

closes #3125

Other information

After Fix:

image
image
image


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: aayushdura <58044533+aayushdura@users.noreply.github.com>
@gitstart
Copy link
Contributor Author

@scopsy This PR is ready for review. Cc: @jainpawan21

@jainpawan21
Copy link
Member

Hi @BiswaViraj
Can you please take a look on this?
some time ago we have to revert back similar change because it was causing issue in iframe and web-component
ref PR:- #3320

@jainpawan21
Copy link
Member

@BiswaViraj ping!

Comment on lines 49 to 51
@media (max-width: 480px) {
padding: 0 10% 0 2%;
}
Copy link
Member

@BiswaViraj BiswaViraj Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@media (max-width: 480px) {
padding: 0 10% 0 2%;
}

You can remove this padding

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitstart and others added 2 commits August 29, 2023 15:48
Copy link
Member

@BiswaViraj BiswaViraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@BiswaViraj BiswaViraj added this pull request to the merge queue Aug 30, 2023
Merged via the queue into novuhq:next with commit 1799a07 Aug 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-1959] 🐛 Bug Report: The Notification Center isn't mobile responsive
3 participants