Nv 2232 to in app notification center provider #3427

davidsoderberg · 2023-05-16T12:14:13Z

No description provided.

…ready-existing feat: add migration to create in app integration

linear · 2023-05-16T12:14:16Z

NV-2232 🔔 to 📡 In-App Notification center provider on integration store

Why? (Context)

Currently, the notification center configuration is scattered across multiple pages including the settings page. This creates for us multiple problems when it comes to understanding if a user has created a notification center integration and etc…

What?

Create an In-App channel integration in the integration store
Treat novu in-app as any other provider in the system
Move the notification center settings to the provider modal
On-boarding discoverability: Show the user how he can integrate Novu using: Iframe, In-App Widget

Definition of Done

The current in-app configuration should be moved to the provider entity (either migration or any other way)
The user should be able to create and enable an in-app integration

Solution

Loom solution guide

Create the In-App section in the integration store

In-App - Integration store (Figma)
Display all possible ways to connect In-App in the integration store

In-App / React / Installation guide - Integration store (Figma)
On click open the POP-UP window with framework settings

In-App / React / Installation guide - Integration store (Figma)

Use scroll to see all information

Email / Scroll down - Integration store (Figma)

Same way we display settings for other frameworks like iFrame or Demo App

🔔 In-App provider - Integration store (Figma)

…p-center-tab-in feat: remove hmac setting in settings

…-2333-update-api-to-use-new-hmac-flag-on

…ac-flag-on Nv 2333 update api to use new hmac flag on

…e-for-active-in feat: add check for active in app integration

feat: add framework select accordion

LetItRock

I've found a few things, but I haven't checked the integration logic. I'll do the rest of the testing later.

When I do create a new org I see this error.
We should remove the body scrollbars when the modal is opened.
I don't see in the design "Configure Later" button
Web Component tile is a little bigger that the others.

apps/api/src/app/widgets/usecases/initialize-session/initialize-session.usecase.ts

apps/web/cypress/tests/changes.spec.ts

apps/web/cypress/tests/integration-store.spec.ts

apps/web/src/pages/integrations/IntegrationsStorePage.tsx

apps/web/src/pages/quick-start/components/SetupTimeline.tsx

apps/web/src/pages/quick-start/steps/NotificationCenter.tsx

apps/api/src/app/environments/environments.controller.ts

apps/api/src/app/channels/channels.controller.ts

davidsoderberg · 2023-05-25T12:50:37Z

I've found a few things, but I haven't checked the integration logic. I'll do the rest of the testing later.

When I do create a new org I see this error.

We should remove the body scrollbars when the modal is opened.

I don't see in the design "Configure Later" button

Web Component tile is a little bigger that the others.

All of these are now resolved. 3 was added to keep it aligned with the quickstart guide.

p-fernandez

Great work. Mostly light touch comments. 👏🏻

p-fernandez · 2023-05-25T13:55:38Z

apps/api/migrations/in-app-integration/in-app-integration.migration.ts

+
+export async function createInAppIntegration() {
+  // eslint-disable-next-line no-console
+  console.log('start migration - in app integration');


Let's replace the console.logs for Logger from @nestjs/common so we can also track the migrations with out telemetry tools. 🤔

We have not done it in migrations this far, but maybe it is a good idea

p-fernandez · 2023-05-25T14:01:17Z

apps/api/src/app/integrations/usecases/get-In-app-activated/get-In-app-activated.usecase.ts

We still need to change the file name and path, right? Still need help with that?

Yes lets try to look at that tomorrow

apps/api/src/app/widgets/e2e/initialize-widget-session.e2e.ts

apps/web/cypress/tests/changes.spec.ts

apps/web/src/components/layout/components/NotificationCenterWidget.tsx

apps/web/src/pages/integrations/components/SetupFrameworkHeader.tsx

apps/web/src/pages/quick-start/components/SetupStatus.tsx

apps/web/src/pages/quick-start/components/SetupTimeline.tsx

davidsoderberg and others added 3 commits May 16, 2023 09:51

feat: add migration to create in app integration

a4012af

feat: add check if in app integration already exists in migration

5f5072d

Merge pull request #3424 from novuhq/nv-2330-create-migrations-for-al…

ae83213

…ready-existing feat: add migration to create in app integration

github-actions bot added @novu/api @novu/shared labels May 16, 2023

davidsoderberg and others added 4 commits May 17, 2023 07:44

feat: change initialize session to use in app integration

56826ed

feat: remove hmac setting in settings

dac8734

fix: remove test for removed setting tab

c323274

Merge pull request #3436 from novuhq/nv-2301-settings-deprecate-in-ap…

4dde058

…p-center-tab-in feat: remove hmac setting in settings

github-actions bot added the @novu/web label May 17, 2023

davidsoderberg and others added 13 commits May 17, 2023 09:22

feat: remove /widget/settings endpoint

88229d1

fix: test

5cf6e05

fix: test

76f87c0

fix: remove old endpoints for old settings

f33a7e0

fix: test

87199a9

Merge branch 'nv-2232-to-in-app-notification-center-provider' into nv…

9279f7c

…-2333-update-api-to-use-new-hmac-flag-on

fix: test

490da67

fix: tests

08f0d8c

fix: tests

a5741e5

fix: tests

3f92467

feat: add check for active in app integration

b8eb64f

Merge pull request #3438 from novuhq/nv-2333-update-api-to-use-new-hm…

4fd7534

…ac-flag-on Nv 2333 update api to use new hmac flag on

Merge pull request #3440 from novuhq/nv-2348-add-check-in-send-messag…

37c260c

…e-for-active-in feat: add check for active in app integration

github-actions bot added the @novu/worker label May 17, 2023

davidsoderberg and others added 5 commits May 17, 2023 14:09

Merge branch 'next' into nv-2232-to-in-app-notification-center-provider

d7eeb0a

Merge branch 'next' into nv-2232-to-in-app-notification-center-provider

0250ad4

feat: add in app card with modal in integration store

c7d69f7

fix: export of circle arrow right icon

e873e4b

feat: add link to quickstart guide

d42ed1f

davidsoderberg requested review from scopsy, BiswaViraj and djabarovgeorge May 24, 2023 08:32

davidsoderberg and others added 7 commits May 24, 2023 12:02

Merge branch 'next' into nv-2232-to-in-app-notification-center-provider

85bb7e0

fix: on configure later callback

aa7167c

Merge branch 'next' into nv-2232-to-in-app-notification-center-provider

41f69a7

feat: add framework select accordion

7d6cd8c

fix: after pr comments

d4a1ba0

Merge pull request #3496 from novuhq/nv-2383-add-new-framework-select-ui

9c98f4f

feat: add framework select accordion

Merge branch 'next' into nv-2232-to-in-app-notification-center-provider

fe82d10

davidsoderberg requested a review from p-fernandez May 25, 2023 06:37

fix: setup framework header for light theme

b2f3ba1

LetItRock requested changes May 25, 2023

View reviewed changes

davidsoderberg added 3 commits May 25, 2023 14:13

fix: after pr comments

4e8d572

fix: after pr comments

f4868b5

fix: so nouv app id is used in notification center

20ff5d0

davidsoderberg requested a review from LetItRock May 25, 2023 12:51

fix: remove unused code

673b9c7

p-fernandez reviewed May 25, 2023

View reviewed changes

fix: after pr comments

6bb281a

LetItRock approved these changes May 25, 2023

View reviewed changes

davidsoderberg added 4 commits May 25, 2023 17:52

fix: after pr comments

0d80548

fix: change so create in app integration happens on button clicks

f5c7dd6

fix: deepsource error

14a34be

fix: switch bug

b0ce13f

davidsoderberg added this pull request to the merge queue May 26, 2023

Merged via the queue into next with commit d14fdd7 May 26, 2023
33 checks passed

davidsoderberg deleted the nv-2232-to-in-app-notification-center-provider branch May 26, 2023 08:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nv 2232 to in app notification center provider #3427

Nv 2232 to in app notification center provider #3427

davidsoderberg commented May 16, 2023

linear bot commented May 16, 2023

Why? (Context)

What?

Definition of Done

Solution

LetItRock left a comment

davidsoderberg commented May 25, 2023 •

edited

p-fernandez left a comment

p-fernandez May 25, 2023

davidsoderberg May 25, 2023

p-fernandez May 25, 2023

davidsoderberg May 25, 2023

Nv 2232 to in app notification center provider #3427

Nv 2232 to in app notification center provider #3427

Conversation

davidsoderberg commented May 16, 2023

linear bot commented May 16, 2023

Why? (Context)

What?

Definition of Done

Solution

LetItRock left a comment

Choose a reason for hiding this comment

davidsoderberg commented May 25, 2023 • edited

p-fernandez left a comment

Choose a reason for hiding this comment

p-fernandez May 25, 2023

Choose a reason for hiding this comment

davidsoderberg May 25, 2023

Choose a reason for hiding this comment

p-fernandez May 25, 2023

Choose a reason for hiding this comment

davidsoderberg May 25, 2023

Choose a reason for hiding this comment

davidsoderberg commented May 25, 2023 •

edited