Nv 2993 reusable in app preview component #5204
Conversation
| } | ||
| `; | ||
|
|
||
| export const NotificationTextstyled = styled.div<{ isExampleNotification: boolean }>` |
There was a problem hiding this comment.
Fixed spellcheck error in my other PR: #5205
| import { | ||
| ContentAndOVerlayWrapperStyled, | ||
| ContentStyled, | ||
| NotificationTextstyled, |
There was a problem hiding this comment.
Spell check error fixed in other PR: #5205
|
All the Light theme related issues are fixed in this PR : #5205 |
ainouzgali
changed the base branch from
translation-management-beta
to
nv-3416-variants-preview
| <Grid mt={24} mb={0}> | ||
| <Grid.Col span={9} p={0}> | ||
| <div style={{ margin: '0 10px' }}> | ||
| <InAppEditorBlock payload={payloadValue} readonly={true} preview={true} /> |
There was a problem hiding this comment.
Inside InAppEditorBlock you will now have a lot of unused code. There it also handles showing the avatar and action buttons.
Just wondering - why not change the styles there?
There was a problem hiding this comment.
I initially thought to use that component but saw it is being used for editing and previewing, which was ok previously because the editor and preview screen were the same in designs.
Now that the design varies a lot for editor and preview. Handling cases like overlay blur will be a little complex; let's separate those into two different components instead of a single component handling editing and previewing. This will also help us make changes to any designs for the editor or preview easier in the future.
I plan to re-use the avatar and action buttons components in the preview instead of new components for those.
…v-2993-reusable-in-app-preview-component
BiswaViraj
force-pushed
the
nv-2993-reusable-in-app-preview-component
branch
from
a226d55
to
6175c21
Compare
…-buttons-preview-for-in-app feat: implement cta and avatar
…-use-default-locale-of-the-organization-as-fallback
…e-organization-as-fallback feat: add fallback lng
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)
Screen.Recording.2024-02-18.at.12.06.38.PM.mov