Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: repeatitive links in the footer #53

Closed
2 tasks done
saimaheshtaduri opened this issue Oct 5, 2022 · 1 comment
Closed
2 tasks done

🐛 Bug Report: repeatitive links in the footer #53

saimaheshtaduri opened this issue Oct 5, 2022 · 1 comment

Comments

@saimaheshtaduri
Copy link

📜 Description

There are two a tags that link to the same url. i.e. both contact us and discord have the same links. I think we can remove the contact us link, as the links to discord, twitter and github are already provided.

👟 Reproduction steps

  1. Scroll to the bottom of the page
  2. See that contact us and discord have the same links

👍 Expected behavior

I think, its better to remove contact us or place all the 3 social handles under the contact us. That makes more sense according to me.

👎 Actual Behavior with Screenshots

The both contact us and discord have same links, I feel there is no use for a contact us link, when there is already discord link in the footer.

💻 Operating system

Windows

🤖 Node Version

v16.150 ( this issue isn't related to node version )

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@scopsy scopsy transferred this issue from novuhq/novu Oct 5, 2022
@scopsy
Copy link
Contributor

scopsy commented Oct 5, 2022

I think that this is ok to have two links for those since people might understand them under a different context differently. I would prefer if until we will create a different channel for contact I believe it's better to leave it as is.

I will be closing this for now, but thank you so much for your contribution!

@scopsy scopsy closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants