Fix unmaking of capturing move #25 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na2hiro
commented
Oct 24, 2020
| @@ -45,7 +45,7 @@ pub enum MoveError { | |||
| PerpetualCheckLose, | |||
| EnemysTurn, | |||
| NonMovablePiece, | |||
| Inconsistent, | |||
| Inconsistent(&'static str), | |||
There was a problem hiding this comment.
Added a message (reason) because it was difficult to understand what's happening
There was a problem hiding this comment.
LGTM, it'd make life a little easier ;)
Comment on lines
-596
to
+605
| self.hand.decrement(cap.flip()); | ||
| let unpromoted_cap = cap.unpromote().unwrap_or(*cap); | ||
| self.hand.decrement(unpromoted_cap.flip()); |
There was a problem hiding this comment.
This is a fix for the first item. The rest is for the second and also for enriching error messages.
nozaq
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues including #25