Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArticleListFilter and PageFilter can't actually use "Ids" #349

Closed
dkershner6 opened this issue Mar 22, 2019 · 4 comments
Closed

ArticleListFilter and PageFilter can't actually use "Ids" #349

dkershner6 opened this issue Mar 22, 2019 · 4 comments

Comments

@dkershner6
Copy link
Contributor

https://github.com/nozzlegear/ShopifySharp/blob/master/ShopifySharp/Filters/ArticleFilter.cs
Inherits from PublishableListFilter and ListFilter, which contains the Ids filter.

https://help.shopify.com/en/api/reference/online-store/article#index

Not actually supported.

I'll let you decide the best approach to remove it while I fix my app!

@dkershner6 dkershner6 changed the title ArticleListFilter can't actually use "Ids" ArticleListFilter and PageFilter can't actually use "Ids" Mar 22, 2019
@nozzlegear
Copy link
Owner

Thanks for the report! So does this throw an error if you try to use it, or just silently "fails" and returns a list?

@dkershner6
Copy link
Contributor Author

The latter. From what I can tell, the list is unaffected from if the parameter were not present.

To be honest, I just assumed Shopify had that parameter, and when ShopifySharp had it, I just assumed it would work. It took a weird bug where things weren't getting updated, besides the first 250, to surface it.

@nozzlegear
Copy link
Owner

I decided to mark this property as obsolete, and will remove it in 5.0

@nozzlegear
Copy link
Owner

Marked obsolete in 4.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants