Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quiet routes in Cambridge #46

Closed
usr110 opened this issue Mar 18, 2016 · 13 comments
Closed

Fix quiet routes in Cambridge #46

usr110 opened this issue Mar 18, 2016 · 13 comments
Assignees

Comments

@usr110
Copy link
Member

usr110 commented Mar 18, 2016

No description provided.

@usr110
Copy link
Member Author

usr110 commented Apr 19, 2016

The data is missing in lines data - lots of variables are missing. I believe new data is needed to be created for Cambridgeshire.

colnames(l@data)
[1] "plan" "start" "finish" "length" "time" "waypoint"
[7] "change_elev" "av_incline" "co2_saving" "calories" "busyness" "id"

It should have these columns - taken from kent:

colnames(l@data)
[1] "id" "Area.of.residence" "Area.of.workplace"
[4] "All" "light_rail" "Bus"
[7] "Taxi" "Motorbike" "Car_driver"
[10] "Car_passenger" "Bicycle" "Foot"
[13] "Other" "govtarget_slc" "govtarget_sic"
[16] "govtarget_slw" "govtarget_siw" "govtarget_sld"
[19] "govtarget_sid" "gendereq_slc" "gendereq_sic"
[22] "gendereq_slw" "gendereq_siw" "gendereq_sld"
[25] "gendereq_sid" "dutch_slc" "dutch_sic"
[28] "dutch_slw" "dutch_siw" "dutch_sld"
[31] "dutch_sid" "ebike_slc" "ebike_sic"
[34] "ebike_slw" "ebike_siw" "ebike_sld"
[37] "ebike_sid" "base_sldeath_webtag" "base_slvalue_webtag"
[40] "govtarget_sldeath_webtag" "govtarget_slvalue_webtag" "govtarget_sideath_webtag"
[43] "govtarget_sivalue_webtag" "gendereq_sldeath_webtag" "gendereq_slvalue_webtag"
[46] "gendereq_sideath_webtag" "gendereq_sivalue_webtag" "dutch_sldeath_webtag"
[49] "dutch_slvalue_webtag" "dutch_sideath_webtag" "dutch_sivalue_webtag"
[52] "ebike_sldeath_webtag" "ebike_slvalue_webtag" "ebike_sideath_webtag"
[55] "ebike_sivalue_webtag" "base_sldeath_heat" "base_slvalue_heat"
[58] "govtarget_sldeath_heat" "govtarget_slvalue_heat" "govtarget_sideath_heat"
[61] "govtarget_sivalue_heat" "gendereq_sldeath_heat" "gendereq_slvalue_heat"
[64] "gendereq_sideath_heat" "gendereq_sivalue_heat" "dutch_sldeath_heat"
[67] "dutch_slvalue_heat" "dutch_sideath_heat" "dutch_sivalue_heat"
[70] "ebike_sldeath_heat" "ebike_slvalue_heat" "ebike_sideath_heat"
[73] "ebike_sivalue_heat" "base_slco2" "govtarget_slco2"
[76] "govtarget_sico2" "gendereq_slco2" "gendereq_sico2"
[79] "dutch_slco2" "dutch_sico2" "ebike_slco2"
[82] "ebike_sico2" "Rail" "dist"
[85] "dist_fast" "dist_quiet" "time_fast"
[88] "time_quiet" "cirquity" "distq_f"
[91] "avslope" "co2_saving" "busyness"
[94] "avslope_q" "clc"

@usr110
Copy link
Member Author

usr110 commented Apr 19, 2016

Generated data for Cambridgeshire (by running load.Rmd) which fixed the issue.

cambridge-dataset

@Robinlovelace
Copy link
Member

Thanks for such a clear issue report Ali. Must be that it didn't run in the national build for some reason. Will look to fix this.

@Robinlovelace
Copy link
Member

@usr110 please can you test that this has worked and re-open if it has not. Pushed onto the main server. Robin

@usr110
Copy link
Member Author

usr110 commented Apr 25, 2016

@Robinlovelace Working fine. Great work!

@Robinlovelace
Copy link
Member

Thanks for the report and the feedback @usr110

@usr110 usr110 reopened this Apr 27, 2016
@usr110
Copy link
Member Author

usr110 commented Apr 27, 2016

It seems both

length
rqincr

still have some issues, as it's showing very weird values.

cambridge-distance

@Robinlovelace
Copy link
Member

Thanks @usr110, please could you see if these exist in any other regions? I'll look into it and fix.

@usr110
Copy link
Member Author

usr110 commented Apr 28, 2016

I have just noticed this issue in cornwall and isles of scilly as well. See below:

cornwall

to further investigate the matter, I have looked into both rf.Rds and rq.Rds and found no abnormal behavirours:

summary(rq@data$length)
Min. 1st Qu. Median Mean 3rd Qu. Max.
0.696 6.904 12.710 13.040 18.580 34.520

summary(rf@data$length)
Min. 1st Qu. Median Mean 3rd Qu. Max. NA's
0.696 6.475 11.560 11.890 16.800 28.130 2

so the issue must be when the region-specific data is be being generated.

@Robinlovelace
Copy link
Member

Thanks for investigating. Those summary datasets are for the regions in which incorrect data is being shown, right?

@usr110
Copy link
Member Author

usr110 commented Apr 28, 2016

yes, robin. Here's summary of Cambridgeshire's rq data:

summary(rq@data$length)
Min. 1st Qu. Median Mean 3rd Qu. Max.
1.062 20.330 9508.000 9828.000 16960.000 29300.000

@Robinlovelace
Copy link
Member

OK great - that will go into the automated data checking script also. Will fix asap.

@nikolai-b
Copy link
Contributor

npct/pct-shiny#237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants