Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up database existence check #1078

Closed
roji opened this issue Oct 13, 2019 · 0 comments · Fixed by #1109
Closed

Clean up database existence check #1078

roji opened this issue Oct 13, 2019 · 0 comments · Fixed by #1109
Assignees
@roji
Labels
bug Something isn't working
Milestone
3.1.0

Comments

@roji
Copy link
Member

roji commented Oct 13, 2019 •
edited
Loading

See dotnet/efcore#18330

Npgsql's existence check is already using unpooled connections for one code path, so dotnet/efcore#18330 isn't an issue. But another path does not - we need to clean this up.
@roji roji added the bug Something isn't working label Oct 13, 2019
@roji roji added this to the 3.0.2 milestone Oct 13, 2019
@roji roji self-assigned this Oct 13, 2019
@roji roji modified the milestones: 3.0.2, 3.1.0 Oct 22, 2019
@roji roji changed the title DatabaseFacade.CanConnect doesn't actually check anything Clean up database existence check Nov 4, 2019
roji added a commit that referenced this issue Nov 4, 2019
@roji
Clean up database existence checks
abe9f3d 
Fixes #1078
@roji roji mentioned this issue Nov 4, 2019
Merged
roji added a commit that referenced this issue Nov 4, 2019
@roji
Clean up database existence checks
ca3d061 
Fixes #1078
roji added a commit that referenced this issue Nov 5, 2019
@roji
Clean up database existence checks
33fa86b 
Fixes #1078
@roji roji closed this as completed in #1109 Nov 5, 2019
roji added a commit that referenced this issue Nov 5, 2019
@roji
Clean up database existence checks
2dce9ae 
Fixes #1078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Clean up database existence checks npgsql/efcore.pg
1 participant
@roji