DDEX VSIX for VS2015RC #598

roji · 2015-05-08T07:12:16Z

Hey @kenjiuno, with VS2015RC out maybe you'll have time to set up a VSIX for it?

kenjiuno · 2015-05-08T12:54:01Z

Hi.

I believe it will work on VS2015RC. Which Npgsql version: 2.2 or 3.0?

roji · 2015-05-08T13:44:26Z

I haven't touched the DDEX provider at all for 3.0, so it should be really identical between the two...

kmschaefer · 2015-05-09T00:45:02Z

I got Visual Studio 2015 RC installed and tried getting version 3.0.0.0 working. When I tried to install the Visual Studio extension, it failed to install. Looking at the install log, it can't find an applicable version of Visual Studio. I don't know how to modify the DDEX provider configuration to force it to install.

5/8/2015 7:51:01 PM - Searching for applicable products...
5/8/2015 7:51:01 PM - Found installed product - Microsoft Visual Studio Professional 2015 RC
5/8/2015 7:51:01 PM - Found installed product - Microsoft Visual Studio Community 2015 RC
5/8/2015 7:51:01 PM - Found installed product - Microsoft Visual Studio 2015 RC Shell (Integrated)
5/8/2015 7:51:01 PM - Found installed product - Global Location
5/8/2015 7:51:01 PM - VSIXInstaller.NoApplicableSKUsException: This extension is not installable on any currently installed products.

kenjiuno · 2015-05-09T01:05:22Z

Hi.

Ok, I will work it on this night... 12 hours later.

Kenji uno 🔰

2015/05/09 9:45、kmschaefer notifications@github.com のメッセージ:

I got Visual Studio 2015 RC installed and tried getting version 3.0.0.0 working. When I tried to install the Visual Studio extension, it failed to install. Looking at the install log, it can't find an applicable version of Visual Studio. I don't know how to modify the DDEX provider configuration to force it to install.

5/8/2015 7:51:01 PM - Searching for applicable products...
5/8/2015 7:51:01 PM - Found installed product - Microsoft Visual Studio Professional 2015 RC
5/8/2015 7:51:01 PM - Found installed product - Microsoft Visual Studio Community 2015 RC
5/8/2015 7:51:01 PM - Found installed product - Microsoft Visual Studio 2015 RC Shell (Integrated)
5/8/2015 7:51:01 PM - Found installed product - Global Location
5/8/2015 7:51:01 PM - VSIXInstaller.NoApplicableSKUsException: This extension is not installable on any currently installed products.

—
Reply to this email directly or view it on GitHub.

roji · 2015-05-09T21:04:09Z

Thanks @kenjiuno :)

kenjiuno · 2015-05-10T15:31:55Z

VS2015RC ddex support will take more times...

Sometimes ddex support will work, but sometimes it won't.

It needs some fixes.

For example, CreateObject will return AdoDotNetConnectionProperties instance for IVsDataConnectionProperties query.

    [Guid(GuidList.guidNpgsqlDdexProviderObjectFactoryString)]
    class NpgsqlProviderObjectFactory : DataProviderObjectFactory
    {
        public override object CreateObject(Type objType)
        {
            if (objType == typeof(IVsDataConnectionProperties) || objType == typeof(IVsDataConnectionUIProperties))
                return new AdoDotNetConnectionProperties();
            else if (objType == typeof(IVsDataConnectionSupport))
                return new AdoDotNetConnectionSupport();
            else if (objType == typeof(IVsDataObjectSupport))
                return new DataObjectSupport(this.GetType().Namespace + ".NpgsqlDataObjectSupport", System.Reflection.Assembly.GetExecutingAssembly());
            else if (objType == typeof(IVsDataViewSupport))
                return new DataViewSupport(this.GetType().Namespace + ".NpgsqlDataViewSupport", System.Reflection.Assembly.GetExecutingAssembly());
            return null;
        }
    }

But, AdoDotNetConnectionProperties doesn't implement IVsDataConnectionProperties.

It sometimes causes ServiceNotFoundException and such.

I'll report progress later.

roji · 2015-05-11T03:43:01Z

Sure @kenjiuno, thanks for all the work :) We probably still have time for the final release of VS2015 anyway.

kenjiuno · 2015-05-11T12:18:15Z

Hi.

I have noticed that some properties cannot be set values. This issue is seen on both Vs2013 and Vs2015.

The exception is thrown at Npgsql.NpgsqlConnectionStringBuilder.GetProperty(String keyword)

I don't really understand why setting property Buffer Size instead of BufferSize. hmm...

roji · 2015-05-11T13:04:09Z

I'll try to take a look ASAP @kenjiuno

roji · 2015-05-12T04:48:11Z

@kenjiuno, I don't understand exactly what's happening... The properties in NpgsqlConnectionStringBuilder have names like BufferSize, only the [DisplayName] attribute is "Buffer Size". AFAIK [DisplayName] is only for showing to the user, does VS try to call GetProperty with it somehow?

kenjiuno · 2015-05-12T05:45:16Z

Thanks for checking it.

only the [DisplayName] attribute is "Buffer Size"

Yea, exactly.

does VS try to call GetProperty with it somehow?

I'll check the property name where it comes from.

roji · 2015-05-12T06:39:52Z

OK @kenjiuno, let me know if I can help in any way. It's also strange because in 2.2 the connection string builder wasn't very different (properties had [Display] etc...)

kenjiuno · 2015-05-12T15:24:21Z

Hi.

It seems to be by design...

AdoDotNetConnectionProperties.ToDisplayString() calls PropertyDescriptor.DisplayName to build connection string. (checked by ILSpy)

I have checked SqlConnectionStringBuilder's "Data Source" for example. http://referencesource.microsoft.com/#System.Data/System/Data/SqlClient/SqlConnectionStringBuilder.cs,399

I don't really understand the detail implementation, but DataSource property looks like just getter/setter for Data Source.

roji · 2015-05-13T09:19:25Z

OK @kenjiuno, I'll take care of this in the connection string builder.

kenjiuno · 2015-05-13T13:26:16Z

Hi.

Is it OK to use NpgsqlConnectionStringProperty as a workaround?

        /// <summary>
        /// Gets or sets the buffer size.
        /// </summary>
#if !DNXCORE50
        [Category("Advanced")]
        [DisplayName("Buffer Size")]
        [Description("Determines the size of the internal buffer Npgsql uses when reading or writing. Increasing may improve performance if transferring large values from the database.")]
        [DefaultValue(NpgsqlBuffer.DefaultBufferSize)]
#endif
        [NpgsqlConnectionStringProperty("Buffer Size")]
        public int BufferSize
        {
        ...
        }

This works well!

Also it needs TryGetValue I have written for 2.x @e70c665edbf7c5672d6f83282aeb69be22edabb6

EDM wizard also works well!

roji · 2015-05-14T04:19:44Z

Great that it's working!

I'll make the change today to the behavior used by SqlClient, it should fix this issue. I'll also do TryGetValue.

@kenjiuno

* Apparently the standard is for the CSB's [DisplayName] to be a valid keyword name (and even the canonical one). Made it so. * Added missing TryGetValue Thanks @kenjiuno Relates to #598

roji · 2015-05-14T05:16:58Z

OK @kenjiuno, I did these changes, the [DisplayName] attribute is now a valid keyword name (and even the canonical one)

Please test and let me know if anything else needs work!

kenjiuno · 2015-05-20T12:57:43Z

Hi sorry for late reply.
I'll test this, thanks!

kenjiuno · 2015-05-23T17:53:43Z

Ok, Npgsql 3.0.0 develop ddex works on VS2013: both EFv5 and EFv6 projects.

roji · 2015-05-23T18:28:30Z

Great work @kenjiuno!

I plan to release 3.0.0-beta1 at some point this week, it would be great to release the DDEX VSIX after it. I'll drop you a note when I release.

franciscojunior · 2015-05-23T19:00:19Z

Excellent work, @kenjiuno!!

JanRou · 2015-05-25T11:38:50Z

I have successfully got Entity Framework 6.1.1 up in VS2015 Community RC. The first attempt failed with Entity Framework 6.1.3. I have followed the Visual Studio Design Time Support DDEX Provider procedure.

I have installed:

VS2015 Community RC - no other Visual Studio is installed.
VS2015 RC SDK
Setup_Npgsql-2.2.5.0-net45-r3
PostgresSQL 9.4 64 bit version

I have created the test console project following the procedure and installed the NuGet packages:

Npgsql version 2.2.5.0
Npgsql 2.2.5.0 for Entity Framework >6.0.0
Entity Framework 6.1.1 (don't use version 6.1.3, because it fails)

Voila the database model appears.

Emill · 2015-05-25T14:39:50Z

Maybe silly question, but have you built your project once?

JanRou · 2015-06-27T20:06:47Z

Yes. I'm looking forward for support of 6.1.3 and especially code first support, which will position Postgres as and complete equivalent and better choice than MS-SQL. You will get database partitioning and ORM for free.

roji · 2015-07-11T21:42:16Z

@kenjiuno, I'm not sure anymore but does the DDEX provider support VS2015? Above we discussed Npgsql 3.0 support more than VS2015... I'm asking because the official release is expected to be July 20th.

kenjiuno · 2015-07-12T15:12:50Z

Hi.

Sorry for long blank.
I'm working on issue #622 : the possibility of non-GAC VSIX installation. There are at least 2 problems to be researched. It will take more than a week...

I'm asking because the official release is expected to be July 20th.

Wow it is almost near future!

Anyway, the most sure way is to do Npgsql GAC installation for DDEX support, for now.
However, I think that incoming Npgsql 3.0 and its EF support DLLs are distributed by NuGet or similar online distribution service.
How about this?

In this situation, I will be able to prepare following things for now:

Npgsql GAC install from your project Look into VSIX for DDEX? #622 (comment)
CheckNpgsqlStatus vsix addon in development stage. https://github.com/kenjiuno/Npgsql/wiki/CheckNpgsqlStatus

roji · 2015-07-12T17:19:09Z

Hey @kenjiuno.

Ah, I didn't know you were working on non-GAC VSIX installation, that's great.

I think that for now there's now urgent need to change how the DDEX provider works - only to make it compatible with VS2015.

For 3.0, it would be great if we could have a simple, clean VSIX that doesn't do anything with the GAC. An actual release of 3.0 is probably 2 weeks away (if nothing serious is reported), so you have time to work on that if you want. If you don't have the time to do it for the 3.0 release, we can always release the DDEX provider a bit later, I don't think it's a big deal...

kenjiuno · 2015-07-14T13:21:22Z

@roji thanks, I'll try non-GAC version!

roji · 2016-05-08T12:30:35Z

Closing this as we have DDEX for VS2015 with Npgsql 3.0.x.

Work on a non-GAC VSIX DDEX extension can be tracked in #622.

roji added the ddex label May 8, 2015

roji assigned kenjiuno May 8, 2015

roji added a commit that referenced this issue May 14, 2015

Fixes to connection string builder

2b26963

* Apparently the standard is for the CSB's [DisplayName] to be a valid keyword name (and even the canonical one). Made it so. * Added missing TryGetValue Thanks @kenjiuno Relates to #598

kenjiuno mentioned this issue Aug 17, 2015

DDEX VSIX fix for VS2015 retail. #718

Closed

roji mentioned this issue Aug 26, 2015

Transaction savepoint methods wrongly changed in 3.x #738

Closed

roji closed this as completed May 8, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DDEX VSIX for VS2015RC #598

DDEX VSIX for VS2015RC #598

roji commented May 8, 2015

kenjiuno commented May 8, 2015

roji commented May 8, 2015

kmschaefer commented May 9, 2015

kenjiuno commented May 9, 2015

roji commented May 9, 2015

kenjiuno commented May 10, 2015

roji commented May 11, 2015

kenjiuno commented May 11, 2015

roji commented May 11, 2015

roji commented May 12, 2015

kenjiuno commented May 12, 2015

roji commented May 12, 2015

kenjiuno commented May 12, 2015

roji commented May 13, 2015

kenjiuno commented May 13, 2015

roji commented May 14, 2015

roji commented May 14, 2015

kenjiuno commented May 20, 2015

kenjiuno commented May 23, 2015

roji commented May 23, 2015

franciscojunior commented May 23, 2015

JanRou commented May 25, 2015

Emill commented May 25, 2015

JanRou commented Jun 27, 2015

roji commented Jul 11, 2015

kenjiuno commented Jul 12, 2015

roji commented Jul 12, 2015

kenjiuno commented Jul 14, 2015

roji commented May 8, 2016

DDEX VSIX for VS2015RC #598

DDEX VSIX for VS2015RC #598

Comments

roji commented May 8, 2015

kenjiuno commented May 8, 2015

roji commented May 8, 2015

kmschaefer commented May 9, 2015

kenjiuno commented May 9, 2015

roji commented May 9, 2015

kenjiuno commented May 10, 2015

roji commented May 11, 2015

kenjiuno commented May 11, 2015

roji commented May 11, 2015

roji commented May 12, 2015

kenjiuno commented May 12, 2015

roji commented May 12, 2015

kenjiuno commented May 12, 2015

roji commented May 13, 2015

kenjiuno commented May 13, 2015

roji commented May 14, 2015

roji commented May 14, 2015

kenjiuno commented May 20, 2015

kenjiuno commented May 23, 2015

roji commented May 23, 2015

franciscojunior commented May 23, 2015

JanRou commented May 25, 2015

Emill commented May 25, 2015

JanRou commented Jun 27, 2015

roji commented Jul 11, 2015

kenjiuno commented Jul 12, 2015

roji commented Jul 12, 2015

kenjiuno commented Jul 14, 2015

roji commented May 8, 2016