Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unmapped composite support #2476

Merged
merged 1 commit into from Jun 3, 2019
Merged

Removed unmapped composite support #2476

merged 1 commit into from Jun 3, 2019

Conversation

YohDeadfall
Copy link
Contributor

Closes #2403.

roji
roji approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @YohDeadfall. See small nit and question, otherwise LGTM.

test/Npgsql.Tests/Types/CompositeTests.cs Outdated Show resolved Hide resolved
test/Npgsql.Tests/Types/CompositeTests.cs Outdated Show resolved Hide resolved
austindrenski
austindrenski approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@austindrenski austindrenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@YohDeadfall YohDeadfall mentioned this pull request May 23, 2019
Merged
@YohDeadfall YohDeadfall merged commit 929fb41 into npgsql:dev Jun 3, 2019
@YohDeadfall YohDeadfall deleted the no-unmapped-composites branch June 3, 2019 11:13
@YohDeadfall YohDeadfall mentioned this pull request Sep 26, 2019
Closed
@kerams
Copy link

kerams commented Nov 17, 2020

So in v5 there is no ExpandoObject, but user-defined composites can be read as strings....?

@YohDeadfall
Copy link
Contributor Author

As a struct or class which must be mapped by invoking MapComposite method as described in the documentation.

@kerams
Copy link

kerams commented Nov 18, 2020

Thanks, I've only seen the FAQ page that the NotSupportedException pointed me to.

@roji
Copy link
Member

roji commented Nov 18, 2020

We've got a breaking change note on that BTW.

@kerams
Copy link

kerams commented Nov 18, 2020 •
edited

Seen that too, it links to the issue mentioned in OP. For someone that didn't know composite type mapping was a thing it did not provide a lot to go on (but I didn't exactly look around much either), that's why I asked here.

Anyway, the Enums and composites docs page still contains a section about dynamic composite type reading. Not sure if it's an oversight or if you're keeping it there for the sake of v4.

@roji
Copy link
Member

roji commented Nov 19, 2020

@kerams thanks for pointing that out - I'll remove the info on dynamic composite mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@austindrenski austindrenski austindrenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop unmapped composite support
4 participants
@YohDeadfall @kerams @roji @austindrenski