Changed mapped composite handler to be lazily initialized #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
May 29, 2019
| length += member.ValidateAndGetLength(value, ref lengthCache); | ||
|
|
||
| return lengthCache.Lengths[position] = length; | ||
| } | ||
|
|
||
| public static MappedCompositeHandler<T> Create(PostgresCompositeType pgType, ConnectorTypeMapper typeMapper, INpgsqlNameTranslator nameTranslator) | ||
| CompositeMemberHandler<T>[] CreateMemberHandlers() => CreateMemberHandlers((PostgresCompositeType)PostgresType, _typeMapper, _nameTranslator); |
There was a problem hiding this comment.
nit: for extra cleanliness we could hide base.PostgresType with a typed new property:
new PostgresCompositeType PostgresType => (PostgresCompositeType)base.PostgresType;There was a problem hiding this comment.
A nice idea. I will use it twice (am working on ctor support), so it makes sense.
There was a problem hiding this comment.
Will do in the next PR since there are some changes in handler. So probably this property would be removed.
austindrenski
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2476 (comment).