Fix breaking change di #5420
Merged
Fix breaking change di #5420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NinoFloris
force-pushed
the
fix-breaking-change-di
branch
from
0b7dc7e
to
85dbe31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5387 (comment)
Shipped and Unshipped are not entirely correct. The default arguments are also tracked so it's not as simple as moving the (BC compatible) overloads introduced in this PR into the Shipped file. As it's only important going forward I'm leaving the entire surface in Unshipped.
BC overloads are both marked EditorBrowsable.Never and Obsolete (Rider for instance does not honor EditorBrowsable but at least won't prefer Obsolete overloads)