-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: explain - mark when dependency is bundled #2750
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2021
if npm/arborist#241 is acceptable, I will update this PR to include a |
darcyclarke
added
Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:patch
semver patch level for changes
labels
Feb 22, 2021
nlf
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great!
wraithgar
added
semver:minor
new backwards-compatible feature
and removed
semver:patch
semver patch level for changes
labels
Feb 25, 2021
wraithgar
force-pushed
the
explain-bundled
branch
from
February 25, 2021 17:51
3ab65c7
to
983d218
Compare
Merged
This was referenced Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: next
These items should be addressed in the next release
Release 7.x
work is associated with a specific npm 7 release
semver:minor
new backwards-compatible feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using
npm explain <package>
its useful to see if the package has been bundled. this is especially useful when trying to understand the provenance of a package's contentit would additionally be helpful to indicate when an edge includes a dependency as bundled, but that will require a change in
@npmcli/arborist
'sEdge.prototype.explain