Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove usage of unnecessary util.promisify #3988

Merged
merged 1 commit into from
Nov 4, 2021
Merged

chore: remove usage of unnecessary util.promisify #3988

merged 1 commit into from
Nov 4, 2021

Conversation

lukekarrys
Copy link
Contributor

This is safe to do now that we've dropped node 10 support.

@lukekarrys lukekarrys requested a review from a team as a code owner November 3, 2021 21:59
wraithgar
wraithgar approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

~/D/n/cli (release-next|✔) $ nvm use 12lts
Now using node v12.13.0 (npm v6.12.0)
~/D/n/cli (release-next|✔) $ node
Welcome to Node.js v12.13.0.
Type ".help" for more information.
> require('fs').promises
{
  access: [AsyncFunction: access],
...

@lukekarrys @wraithgar
chore: remove usage of unnecessary util.promisify
32ccd3c 
This is safe to do now that we've dropped node 10 support.

PR-URL: #3988
Credit: @lukekarrys
Close: #3988
Reviewed-by: @wraithgar
@wraithgar wraithgar merged commit 32ccd3c into release-next Nov 4, 2021
@wraithgar wraithgar deleted the lk/fs.promises branch November 4, 2021 14:10
@wraithgar wraithgar mentioned this pull request Nov 4, 2021
Merged
@npm-robot npm-robot mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukekarrys @wraithgar