fix: explicitly allow npm help to open file:/// man pages
#4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
open-url would likely benefit from a refactor but that's a future task |
isaacs
approved these changes
Nov 10, 2021
wraithgar
added a commit
that referenced
this pull request
Nov 10, 2021
PR-URL: #4026 Credit: @wraithgar Close: #4026 Reviewed-by: @isaacs
wraithgar
force-pushed
the
gar/help-open-file
branch
from
c428956
to
cd6d3a9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This url is trusted input as it is generated from our own man pages