Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont warn on error cleaning individual log files #4134

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

lukekarrys
Copy link
Contributor

Closes: #4128

This also refactors the logic for cleaning log files to use the ignore
option from glob to not clean current log files instead of relying on
updating the logs-max count.

I also discovered a bug where we weren't cleaning log files written with
the old naming convention, so this fixes that as well.

@lukekarrys lukekarrys requested a review from a team as a code owner December 7, 2021 03:54
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one tiny suggestion is in a test file and not a big deal.

Closes: #4128

This also refactors the logic for cleaning log files to use the `ignore`
option from `glob` to not clean current log files instead of relying on
updating the `logs-max` count.

I also discovered a bug where we weren't cleaning log files written with
the old naming convention, so this fixes that as well.

PR-URL: #4134
Credit: @lukekarrys
Close: #4134
Reviewed-by: @wraithgar
@lukekarrys lukekarrys merged commit 08c6639 into release-next Dec 8, 2021
@lukekarrys lukekarrys deleted the lk/clean-logs branch December 8, 2021 22:43
@npm-robot
Copy link
Contributor

found 4 benchmarks with statistically significant performance improvements

  • app-large: modules-only, no-lock
  • app-medium: modules-only, no-lock

found 1 benchmarks with statistically significant performance regressions

  • app-large: clean
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 54.823 ±0.47 30.141 ±0.25 27.193 ±12.62 20.576 ±0.81 28.462 ±2.05 8.786 ±0.01 2.546 ±0.01 12.396 ±0.05 2.551 ±0.03 3.359 ±0.01
#4134 61.977 ±2.92 32.494 ±0.29 29.167 ±13.60 21.809 ±0.83 3.314 ±0.16 3.256 ±0.02 2.630 ±0.02 12.776 ±0.02 2.615 ±0.02 3.602 ±0.20
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 38.298 ±2.65 23.933 ±0.33 13.802 ±0.15 14.775 ±0.21 18.655 ±1.18 7.997 ±0.04 2.653 ±0.00 9.380 ±0.13 2.488 ±0.06 3.067 ±0.06
#4134 39.496 ±4.09 25.510 ±0.07 14.564 ±0.22 15.398 ±0.13 2.911 ±0.02 2.974 ±0.02 2.625 ±0.04 9.696 ±0.03 2.510 ±0.02 3.217 ±0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants