Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm explore shell spawning without arguments immediately terminates (!isWindows) #783

Closed
jasisk opened this issue Feb 7, 2020 · 1 comment
Labels
Bug thing that needs fixing

Comments

@jasisk
Copy link
Contributor

jasisk commented Feb 7, 2020

What / Why

The shell spawned by npm explore <package> (no additional arguments) terminates immediately.

When

npm explore <package>

Where

npm cli

How

The shell is spawned erroneously with the arguments ['-c', '']. This is because of a faulty args truthiness check rather than a length check.

Current Behavior

$ echo $SHLVL
1

$ npm explore packagename

$ echo $SHLVL
1

Steps to Reproduce

npm explore <packagename>

Expected Behavior

$ echo $SHLVL
1

$ npm explore packagename

Exploring /path/to/node_modules/packagename
Type 'exit' or ^D when finished

$ echo $SHLVL
2

Who

  • @npm/cli-team

References

  • n/a
@darcyclarke darcyclarke added the Bug thing that needs fixing label Oct 30, 2020
@darcyclarke
Copy link
Contributor

npm v6 is no longer in active development; We will continue to push security releases to v6 at our team's discretion as-per our Support Policy.

If your bug is preproducible on v7, please re-file this issue using our new issue template.

If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo

Closing: This is an automated message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@jasisk @darcyclarke and others