This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
chore: Modernize, update dependencies #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdickinson
approved these changes
Jan 12, 2018
| const Promise = require('bluebird') | ||
| const path = require('path') | ||
| const _ = require('lodash') | ||
| const fs = require('fs') |
| if (!path) return P.cast(null); | ||
|
|
||
| return new P(function(resolve, reject) { | ||
| fs.readFile(path, 'utf-8', function(err, source) { |
There was a problem hiding this comment.
(Oh odd, I did not know that node supported utf-8 in addition to utf8.)
Not initially. This will be used directly by wubwub. If/when we upgrade email-queue to use this version as well, we will also have to upgrade it to node 8. This module is effectively a mustache and monocle atop SES, so there's little harm in keeping around an old version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still get a warning about a deprecated
node-uuidthroughhandlebars-async, but that project hasn't been touched in 4 years...