Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong return value documented for maxSatisfying #20

Closed
tlindig opened this issue Feb 1, 2013 · 1 comment
Closed

wrong return value documented for maxSatisfying #20

tlindig opened this issue Feb 1, 2013 · 1 comment

Comments

@tlindig
Copy link

tlindig commented Feb 1, 2013

If maxSatisfying fails it returns undefined, not null.

So the README.md should corrected. There is written:

maxSatisfying(versions, range): Return the highest version in the list
that satisfies the range, or null if none of them do.
@isaacs
Copy link
Contributor

isaacs commented Feb 1, 2013

Patch welcome (to either make it return null, or update the doc.)

@sethkinast sethkinast mentioned this issue Mar 6, 2013
Closed
@isaacs isaacs closed this as completed in 160e5ae Apr 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaacs @tlindig