Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

wrong return value documented for maxSatisfying #20

Closed
tlindig opened this Issue · 1 comment

2 participants

@tlindig

If maxSatisfying fails it returns undefined, not null.

So the README.md should corrected. There is written:

maxSatisfying(versions, range): Return the highest version in the list
that satisfies the range, or null if none of them do.
@isaacs
Owner

Patch welcome (to either make it return null, or update the doc.)

@sethkinast sethkinast referenced this issue from a commit
@sethkinast sethkinast maxSatisfying() should return null if no versions satisfy the range. …
…Fixes #20

Keep maxSatisfying comment in sync with behavior
2c66f7a
@isaacs isaacs closed this issue from a commit
@sethkinast sethkinast maxSatisfying return null if no versions satisfy
Fix #20

Keep maxSatisfying comment in sync with behavior
160e5ae
@isaacs isaacs closed this in 160e5ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.