Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

"engines" seems to be ignored #12486

Open
naholyr opened this issue Apr 26, 2016 · 8 comments
Open

"engines" seems to be ignored #12486

naholyr opened this issue Apr 26, 2016 · 8 comments

Comments

@naholyr
Copy link

naholyr commented Apr 26, 2016

Scenario:

  • just published copycast@5.0.1 (tagged "next") which targets node ≥ 6.0.0
  • when I run npm i -g copycast@next (from another directory, to be sure it's not related to my cwd) using node 5.10.1 / npm 3.8.3, install works fine, no warning
  • I expected a failure :(

package.json:

…
  engineStrict: true,
  engines: { node: '>= 6.0.0' },
…

Note: I'm aware that "engines" is ignored when you npm install your module from its working directory, this is not the situation described here.

@MiLk
Copy link

MiLk commented Apr 28, 2016

It seems to be broken since npm v3.6.0.

screen shot 2016-04-28 at 12 30 31 pm

screen shot 2016-04-28 at 12 34 42 pm

@naholyr
Copy link
Author

naholyr commented Apr 28, 2016

Thanks for the test, I may have messed up during mines because at some point installs even with npm@2 it was ignored, but I used "engine", "engines", different syntaxes, tried anything :D

As it's a simple warning anyway, I'll go with a preinstall script I guess.

@iarna
Copy link
Contributor

iarna commented May 2, 2016

The warnings should show up after your install completes now, after the summary install tree.

@iarna
Copy link
Contributor

iarna commented May 2, 2016

(The goal being to highlight the warnings better when you have a full screen summary tree.)

@MiLk
Copy link

MiLk commented May 3, 2016

Nothing is showing up.

npm v3.6.0
2016-05-03-103649_415x674_scrot
2016-05-03-103613_874x988_scrot

npm v3.8.8
2016-05-03-104001_384x300_scrot
2016-05-03-104011_799x309_scrot

@naholyr
Copy link
Author

naholyr commented May 3, 2016

Nope I never had any warning, before or after summary tree. Today I
replaced the mention by a preinstall script doing the job as intended
(triggered before useless downloads and blocking installation as it won't
work anyway).

On Tue, May 3, 2016 at 3:41 AM Emilien Kenler notifications@github.com
wrote:

Nothing is showing up.

npm v3.6.0
[image: 2016-05-03-103649_415x674_scrot]
https://cloud.githubusercontent.com/assets/29782/14972800/03417a00-111b-11e6-849b-5cf081941f9f.png
[image: 2016-05-03-103613_874x988_scrot]
https://cloud.githubusercontent.com/assets/29782/14972801/0343c616-111b-11e6-9b96-51f0c360bf53.png

npm v3.8.8
[image: 2016-05-03-104001_384x300_scrot]
https://cloud.githubusercontent.com/assets/29782/14972833/70060426-111b-11e6-891f-66e04e248d48.png
[image: 2016-05-03-104011_799x309_scrot]
https://cloud.githubusercontent.com/assets/29782/14972832/6fe52602-111b-11e6-9f78-d5483bd2f670.png


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#12486 (comment)

@jdalton
Copy link
Contributor

jdalton commented Sep 6, 2016

Seeing this issue in npm -v 2.15.1. When installing dev deps locally npm i I don't get a warning.

@nicolasnoble
Copy link

I'm fairly impressed that this issue doesn't have any more traction that this. One documented feature of npm hasn't been working for more than two years now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants