npm 5 fails to install git dependencies from gerrit

[remcohaszing]

I'm opening this issue because:

• npm is crashing.
• npm is producing an incorrect install.
• npm is doing something I don't understand.
• Other (see below for feature requests):

What's going wrong?

npm 5 crashed when I try to install a dependency from a Gerrit host. This worked fine when using npm 4.x.

I have the following dependency:

  "project_name": "git+https://$GERRIT_HOST/gerrit/$GERRIT_PROJECT_NAME#$GIT_HASH",

npm crashes on the following command (I rewrote it a bit replacing actual values with representative environment variables):

$ REFSPEC=$GERRIT_PROJECT_ID/$GERRIT_SHORT_CHANGE_ID/$GERRIT_PATCHSET
$ git clone --depth=1 -q -b $REFSPEC https://$GERRIT_HOST/gerrit/$GERRIT_PROJECT_NAME $HOME/.cache/npm/_cacache/tmp/git-clone-74d2e568
warning: Could not find remote branch $REFSPEC to clone.
fatal: Remote branch $REFSPEC not found in upstream origin

The following does work:

git clone --depth=1 https://$GERRIT_HOST/gerrit/$GERRIT_PROJECT_NAME
git fetch https://$GERRIT_HOST/gerrit/$GERRIT_PROJECT_NAME refs/changes/$REFSPEC
git checkout FETCH_HEAD

How can the CLI team reproduce the problem?

The team needs to try to depend on a git dependency from a Gerrit host. Since I'm using a private host, I can't give any further information.

supporting information:

• npm -v prints: 5.0.0
• node -v prints: v7.10.0
• npm config get registry prints: https://registry.npmjs.org/
• Windows, OS X/macOS, or Linux?: Linux
• Network issues:
  • Geographic location where npm was run:
  • I use a proxy to connect to the npm registry.
  • I use a proxy to connect to the web.
  • I use a proxy when downloading Git repos.
  • I access the npm registry via a VPN
  • I don't use a proxy, but have limited or unreliable internet access.
• Container:
  • I develop using Vagrant on Windows.
  • I develop using Vagrant on OS X or Linux.
  • I develop / deploy using Docker.
  • I deploy to a PaaS (Triton, Heroku).

[zkat]

Ooh this is probably some weird detail with shell expansion in pacote.

[apaleslimghost]

I have something similar with git dependencies from Bitbucket Server.

the line in package.json:

"circular-list": "git+ssh://git@[REDACTED]/circular-list.git#v1.0.2",

output:

npm ERR! code 128
npm ERR! Command failed: /usr/local/bin/git clone --depth=1 -q -b v1.0.2^{} ssh://git@[REDACTED]/circular-list.git /Users/matthew.brennan/.npm/_cacache/tmp/git-clone-d9115048
npm ERR! warning: templates not found /var/folders/0m/smmrszcj367g1ds3nkjrv2y42l6kl3/T/pacote-git-template-tmp/git-clone-410ac485
npm ERR! fatal: Remote branch v1.0.2^{} not found in upstream origin
npm ERR!

[zkat]

@quarterto could you file this as an issue against https://github.com/zkat/pacote? This is definitely a hiccup with ref parsing pacote-side.

[apaleslimghost]

@zkat done: zkat/pacote#90

[jaslo]

I have a similar problem -- no crash, but no install either with dependencies from amazon codecommit.
git+ssh://git-codecommit.us-east-1.amazonaws.com/v1/repos/myreponame

[zkat]

@remcohaszing I just pushed out npm@5.0.1 with a bunch of fixes. Could you give that a whirl and let me know if it fixed this?

[remcohaszing]

@zkat I just npm@5.0.1, but it doesn't make a difference.

[zkat]

@remcohaszing then I guess you're using a git@foo.com:user/project format ssh URI? That's the type that's currently known to be broken.

[zkat]

(I'm fixing this right now, btw)

[zkat]

And here's the PR: npm/npm-package-arg#24

[zkat]

Closing as a duplicate of #16726

[remcohaszing]

This issue still persists in npm@5.0.2, which I believe has been fixed.

@remcohaszing then I guess you're using a git@foo.com:user/project format ssh URI? That's the type that's currently known to be broken.

No, it's git+https://foo.com/path/to/project. (It's in the original issue description.)

[zkat]

Reopening. If the previous patch didn't work, I think this is likely to have to do with #16898, which is fixed by zkat/pacote#97.

I've released a new npm canary with this patch: npmc@5.0.2-canary.8. You can install it with npm i -g npmc@5.0.2-canary.8. If you have the time, please try that and see if it fixes it. Otherwise, I guess there's yet another fun new surprise to figure out :P

[remcohaszing]

I suppose that patch got merged in 5.0.3, because everything works now. 😄

[zkat]

😎 cool. Thanks for trying it out 👍

[zkat]

And like, seriously, thanks y'all for reporting all this and letting me flop around a bit about it. git stuff needed some love ^_^;;