Skip to content
This repository has been archived by the owner on Jul 10, 2018. It is now read-only.

README.md not updating across publishes. #3

Closed
cchamberlain opened this issue Jul 8, 2016 · 4 comments
Closed

README.md not updating across publishes. #3

cchamberlain opened this issue Jul 8, 2016 · 4 comments

Comments

@cchamberlain
Copy link

I've been trying to publish updates to the README.md for package react-pub-sub. It is part of a lerna repo at the moment and therefore some of the links to its git repo do not actually exist yet (my understanding is that README is not pulled from git so shouldn't be a problem). I have published a few patch / minor versions now and the README has not reflected.

git --version: 2.8.1.windows.1

npm --version: 3.10.6 (linked)

package.json

{
  "name": "react-pub-sub",
  "version": "0.7.0",
  "description": "Factory for creating prop and state propagation between 1:N React components.",
  "main": "lib/index.js",
  "files": [
    "lib"
  ],
  "keywords": [
    "react",
    "pubsub",
    "publish",
    "subscribe",
    "propagate",
    "propagation"
  ],
  "scripts": {
    "start": "run-p build-watch",
    "clean": "run-p clean-lib clean-doc",
    "clean-lib": "rimraf lib",
    "clean-doc": "rimraf doc",
    "prebuild": "npm run clean",
    "build": "babel src/lib -d lib",
    "build-watch": "npm run build -- --watch",
    "release": "npm version patch && npm publish",
    "postrelease": "npm run release-gh-pages",
    "prerelease-gh-pages": "npm run doc",
    "release-gh-pages": "run-s gh-pages-subtree gh-pages-push gh-pages-delete",
    "postrelease-gh-pages": "npm run clean-doc && npm run git-save -- clean && git push -u origin master --follow-tags",
    "predoc": "rimraf doc",
    "doc": "esdoc -c ./esdoc.json && ncp CNAME doc/CNAME",
    "postdoc": "npm run git-save -- doc",
    "gh-pages-subtree": "git subtree split --prefix doc -b gh-pages",
    "gh-pages-push": "git push -f origin gh-pages:gh-pages",
    "gh-pages-delete": "git branch -D gh-pages",
    "git-save": "git add -A && git commit -am ",
    "upgrade": "ncu -a && npm update"
  },
  "dependencies": {
    "babel-runtime": "^6.9.0",
    "chai": "^3.5.0",
    "eventemitter3": "latest",
    "ncp": "^2.0.0",
    "react-stamp": "latest",
    "solvent": "^0.7.0"
  },
  "devDependencies": {
    "babel-cli": "^6.9.0",
    "babel-core": "^6.9.0",
    "babel-eslint": "^6.0.4",
    "babel-loader": "^6.2.4",
    "babel-plugin-react-transform": "^2.0.2",
    "babel-plugin-transform-runtime": "^6.9.0",
    "babel-polyfill": "*",
    "babel-preset-es2015": "^6.9.0",
    "babel-preset-react": "^6.5.0",
    "babel-preset-stage-0": "^6.5.0",
    "babel-register": "^6.9.0",
    "esdoc": "^0.4.7",
    "esdoc-es7-plugin": "0.0.3",
    "eslint": "^2.12.0",
    "eslint-plugin-babel": "*",
    "eslint-plugin-react": "*",
    "faker": "^3.1.0",
    "mocha": "^2.5.3",
    "npm-run-all": "^2.1.1",
    "react": "^15.1.0",
    "react-addons-test-utils": "^15.1.0",
    "react-dom": "^15.1.0",
    "react-tools": "^0.13.3",
    "rimraf": "^2.5.2"
  },
  "author": "Cole Chamberlain <cole.chamberlain@gmail.com> (https://github.com/cchamberlain)",
  "bugs": {
    "url": "https://github.com/noderaider/react-pub-sub/issues"
  },
  "homepage": "https://react-pub-sub.js.org",
  "license": "MIT",
  "repository": {
    "type": "git",
    "url": "git+https://github.com/noderaider/react-pub-sub.git"
  }
}

.npmignore

# Logs
logs
*.log

# Runtime data
pids
*.pid
*.seed

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Dependency directory
# Commenting this out is preferred by some people, see
# https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git
node_modules
docs/html

# Users Environment Variables
.lock-wscript

.DS_Store

@rockbot
Copy link
Contributor

rockbot commented Jul 29, 2016

@cchamberlain: are you still experiencing this issue?

@cchamberlain
Copy link
Author

@rockbot yep. This is the readme in the directory i'm publishing from and corresponding package.json. You can see that the package.json version on react-pub-sub matches the 0.12.0 in the package.json, yet the README.md has not been updated since the initial push (I believe).

I'm guessing this is maybe related to the package being part of a lerna repo and having incorrect git repo fields in package.json although I've read that git is not used for syncing of the README.md.

@zpao
Copy link

zpao commented Aug 1, 2016

I'm also experiencing this with https://www.npmjs.com/package/react-test-renderer. We published a new version Friday and the new readme hasn't shown up.

In case it's helpful in diagnosing, the publish approach I used was similar to (the same as?) what lerna does - publish to next dist-tag and then use dist-tag add to update the latest tag.

FYI: There was an old issue in a deleted repo saying that this pattern might be a cause of the issue.

@rockbot
Copy link
Contributor

rockbot commented Aug 1, 2016

Ultimately, this is a registry issue, which will be best handled by the registry team. I've gone ahead and created the issue for you: https://github.com/npm/registry/issues/42; please feel free to comment further on there :-)

(As a result, I'm going to close this one in here :-))

@rockbot rockbot closed this as completed Aug 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants