Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow not managing table settings #21

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Conversation

reidmv
Copy link
Contributor

@reidmv reidmv commented Oct 12, 2018

This is to provide for situations, like in the PE Extra Large
architecture, where the PuppetDB database does not exist on the
PostgreSQL system being tuned. In PE XL, the master and the master
replica run a PostgreSQL system for all databases except for PuppetDB.

This is to provide for situations, like in the PE Extra Large
architecture, where the PuppetDB database does not exist on the
PostgreSQL system being tuned. In PE XL, the master and the master
replica run a PostgreSQL system for all databases *except* for PuppetDB.
@npwalker
Copy link
Contributor

Technically this can already be achieved by setting the parameters on table_settings to false or undef as appropriate.

The only thing I'm contemplating is if manage_postgresql_settings false should be the thing that causes table_settings to not be included. I think it's a logical error that there's no way to avoid that in the present case.

@reidmv
Copy link
Contributor Author

reidmv commented Oct 12, 2018

@npwalker ok. Let me know what conclusion you arrive at on what should be done. I'm happy to make changes or close this PR based on your decision.

@npwalker npwalker merged commit b8f2fef into puppetlabs:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants