Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various CMake cleanups #152

Merged
merged 5 commits into from
Jun 10, 2022
Merged

Various CMake cleanups #152

merged 5 commits into from
Jun 10, 2022

Commits on Jun 10, 2022

  1. build: depend cmake options on parent options 

    Some CMake options only make sense to enable/show to the user
if another CMake option is enabled.

For example, setting BUILD_MNL_LIB=ON/OFF only makes sense
if we're actually using libmnl when USE_NETLINK_SERVICE=ON
    @aloisklink
    aloisklink committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    14360e5 View commit details
    Browse the repository at this point in the history

  2. build: remove LIB_MAKEFLAGS references 

    LIB_MAKEFLAGS was used to pass makeflags to
libraries that were being compiled at configure time.

As of #150 being merged, all libraries are now compiled at
compile time, so this variable is no longer needed.
    @aloisklink
    aloisklink committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    aba44f8 View commit details
    Browse the repository at this point in the history

  3. build: remove unused CMake defines

    @aloisklink
    aloisklink committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a80509e View commit details
    Browse the repository at this point in the history

  4. build(libnetlink): allow setting CMAKE_BUILD_TYPE 

    Previously, libnetlink was harded to compile in DEBUG mode.
Now it should inherit EDGESec's compile mode.
    @aloisklink
    aloisklink committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    dd916f9 View commit details
    Browse the repository at this point in the history

  5. build: swap -fpic with POSITION_INDEPENDENT_CODE 

    POSITION_INDEPENDENT_CODE is the preferred way
of enabling this in CMAKE, see
https://cmake.org/cmake/help/latest/prop_tgt/POSITION_INDEPENDENT_CODE.html
    @aloisklink
    aloisklink committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    8bc918a View commit details
    Browse the repository at this point in the history