Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gto soil properties #62

Closed
wants to merge 15 commits into from
Closed

Gto soil properties #62

wants to merge 15 commits into from

Conversation

mpraprost
Copy link
Contributor

Pull request overview

Adds soil conductivity and undisturbed ground temperature as additional properties to the building. Values are not used unless geothermal heat pump upgrade measures are run. Does not affect baseline, no change documentation required.

  • Fixes #ISSUENUMBERHERE (IF RELEVANT)

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

Praprost and others added 15 commits October 18, 2023 12:57
make direct evap coolers NA, switch to using performance data, expand unit tests to all applicable system types
soil conductivity has a distribution per climate zone and is added to buildstock.csv sampling. undisturbed ground temp is a fixed value per climate zone and is added in the measure. change buildinglocation measure adds these two values as additionalproperties to the building, and then are used later in geothermal heat pump upgrade measures.
@mpraprost mpraprost added the workflow measure PR improves or adds baseline workflow measures label Dec 22, 2023
@mpraprost mpraprost closed this Dec 22, 2023
@mpraprost mpraprost removed the request for review from mdahlhausen December 22, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants