Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update design levels and fractions for kitchen equipment #66

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

mpraprost
Copy link
Contributor

@mpraprost mpraprost commented Dec 27, 2023

Pull request overview

Updates design levels and heat gain fractions for gas and electric kitchen equipment to align with ASHRAE Fundamentals wherever possible. In addition, electric kitchen equipment schedules were altered to follow the same schedules as gas equipment. This was done in preparation for the Electric Kitchen Equipment measure to ensure consistent sources and comparable equipment specifications and schedules are used when modeling electrification of appliances. See change documentation called "v24 Kitchen Equipment Updates".

  • Fixes #ISSUENUMBERHERE (IF RELEVANT)

Pull Request Author

Marley

This pull request makes changes to (select all the apply):

  • [] Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • [] Perform a code review on GitHub
  • [] All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • [] Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@mpraprost mpraprost added the workflow measure PR improves or adds baseline workflow measures label Dec 27, 2023
previously, the electric equipment schedules were higher than gas, therefore when gas equipment was replaced with electric there was still an increase in annual load despite more efficient equipment

miscellaneous electric equipment object still gets electric equip schedule
@mpraprost
Copy link
Contributor Author

mpraprost commented Jan 10, 2024

@ChristopherCaradonna @eringold this PR is now ready. Please review the change document and let me know if there is anything else you'd like added. Eric I added you to this since this change doc also includes the PVAV change.

Copy link
Contributor

@ChristopherCaradonna ChristopherCaradonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Approved.

@ChristopherCaradonna ChristopherCaradonna merged commit c0b995e into main Jan 17, 2024
@ChristopherCaradonna ChristopherCaradonna deleted the modify_baseline_kitchen_equip branch January 17, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants