Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Failing tests due to pandas pd.concat #21

Closed
1 task done
bayc opened this issue Sep 2, 2022 · 3 comments
Closed
1 task done

[BUG] Failing tests due to pandas pd.concat #21

bayc opened this issue Sep 2, 2022 · 3 comments
Assignees

Comments

@bayc
Copy link
Collaborator

bayc commented Sep 2, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The test df_time_operations.py is failing due to type errors. The issue has been traced to a pd.concat call in time_operations.py where a column is trying to be added, but instead, rows are added with the column.

Expected Behavior

The test should pass.

Steps To Reproduce

Run pytest df_time_operations.py in the tests directory.

Environment

- OS: Ubuntu 20.04
- pip environment (can be retrieved with `pip list`):
  - pandas 1.4.4
  - numpy 1.21.5
  - scipy 1.8.0

Anything else?

None.

@misi9170
Copy link
Collaborator

misi9170 commented Sep 5, 2022

This seems to be at least partly due to the new version of pandas. Looking into this now.

@misi9170
Copy link
Collaborator

misi9170 commented Sep 5, 2022

Have submitted pull request for review on this issue.

paulf81 added a commit that referenced this issue Oct 5, 2022
* Rewrote the moving average function

Co-authored-by: Paul <paul.fleming@nrel.gov>
@paulf81
Copy link
Collaborator

paulf81 commented Oct 18, 2022

Resolved by pull request #23

@paulf81 paulf81 closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants