-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indents not being applied in noweave output #24
Comments
I can't duplicate the problem. (The indentation is fine for me.) What's the checksum on your
If yours is different, let's see it. Details about your system, please? I've got
|
I did get a different checksum. Here's
And here's my tex version:
|
Your .tex file works correctly for me in pdflatex. I'm not sure where your Noweb installation comes from, |
Hmm, I cloned noweb from git. I can delete it all and try again... |
I tried it in two different ways:
In both cases, indents were not applied. This was all using TeX Live 2022. I installed TeX Live 2019, and got the indents. So there is something that happened in TeX Live 2020, 2021, or 2022 that is causing whatever noweb uses to indent to not work anymore. I don't really want to use 2019 because usually the latest version of TeX Live is recommended, and
And then that page has a big notice on it about how upgrading is dangerous and you should just install the latest version. |
OK, I can well believe it's a TeXlive issue. I've been bitten before. I'm running Debian stable. That's TeXlive 2020. It looks like TeXlive Maybe there's an easier way of setting up a test environment? |
I'm ok with having to use a stable version -- I can just Probably best to leave this bug open and revisit when the major stable releases pin TeX Live to 2021 or 2022. As for a test environment, you should be able to install 2022 in parallel with 2020, but you'd probably have to change some env variables like Then again, it's hard to know whether the installation is hermetic. Docker is probably the best option here. |
Works correctly on TeXLive 2021 (Ubuntu 22.04 LTS). I can reproduce that it works incorrectly on TeXLive 2022:
Yields: |
I've been bitten by this on MikTeX, too. I'm not sure what's going on. The |
Not just on Tex Live, but MikTeX also has this issue with its latest updates. |
I've made some progress on this. In support.nw, chunk 8b, the definition of
This appears to be where the problem occurs. It looks like there might be some clobbering of catcodes or the like. Chunk 10c includes the code that we want, namely, Strangely, I've found that if you swap the above two lines, then things work, that is, if you fix spaces after |
It's great to hear of some progress here, but I'm about to go on vacation for three weeks, then business travel. I'll try to remember to get back to this around the beginning of October. |
Hello i also stumpled about this problem with the Update to TexLive 2022 in Debian. If some provide me a patched file I will be able to test it . |
…ng the idee from arcfide and test it.
This problem, or one indistinguishable from the description above, is now seen with Noweb 2.12 on the Slackware 15.0 platform. There was a recent security patch to TeX Live by the Slackware 15.0 maintainers. The patch brought TeX Live forward from texlive-2021.210418 to texlive-2023.230322. With texlive-2023.230322, indentation is broken. Reverting to texlive-2021.210418 restores the correct indentation behavior. Is the request still open for access to a system on which to test? |
Hello,
you can use the patch also to path your version of noweb under slackware
as I did it for Debian
It will be released as stable next weekend.
I already use it regularly.
Kind regards
Am 06.06.23 um 14:43 schrieb meta-ed:
… This problem, or one indistinguishable from the description above, is now seen with Noweb 2.12 on the Slackware 15.0 platform. There was a recent security patch to TeX Live by the Slackware 15.0 maintainers. The patch brought TeX Live forward from texlive-2021.210418 to texlive-2023.230322. With texlive-2023.230322, indentation is broken. Reverting to texlive-2021.210418 restores the correct indentation behavior.
Is the request still open for access to a system on which to test?
--
Mechtilde Stehmann
## Debian Developer
## PGP encryption welcome
## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F
|
Fantastic. I will put it on my list for after the latest stable release this weekend. |
Fixed. If anybody wants to try it out, I'll take the "RC" off the version tag. |
There is an unexpected dependency on the
I do not find |
Thanks for catching this bug. I've pushed v2_13rc3, which seems to resolve it. |
I see rc2 but not rc3. I'll look again tonight. |
My bad. I pushed the commit but not the tag. |
Making progress! The build now fails at: EDIT: I'm using the Slackware 15.0 build script that was developed for 2.12 to produce the binary package for Slackware 15. As I look deeper into it, apparently $DESTDIR is patched in by the build script maintainer exactly for this reason. So I need to go back and update that patch to work with 2.13. |
I accepted a PR that made several changes to the Makefiles, |
A script by Kyle Guinn builds 2.12 for Slackware 15.0. That script applies a patch to 2.12 makefiles before running Going by Kyle's patch, I patched 2.13rc3, and successfully created a binary distribution of 2.13rc3. Then I tested these four cases: Texlive 2021, Noweb 2.12 -- works Example of what the patch does:
becomes
|
Frankly, if I were writing such a patch, I'd be patching lines 22 to 28 and leaving the rest alone. That's the procedure suggested in step 1 of the INSTALL file. An even better plan would be to create a shell script that invokes Make while setting those variables on the command line. Obviously, Slackware can do as it likes. |
I doubt I'll explain this well, but I'll try. And maybe you understand this already, and I'm not understanding the Noweb makefiles. If so I apologize for wasting your time. The problem is not specific to Slackware. Any time an application is to be packaged as a binary tarball, the build procedure can't install the pieces to the running system library. The pieces need to go into an empty tree that can be tarballed and later extracted to target systems. That's easily done by editing lines 22 to 28. I can set Now the pathnames in the resulting tarball will not include the But the change in pathname breaks Noweb at run-time. For example, |
Ah, I think I see the problem. The expectation is as follows:
Such functionality could be provided by altering @Mechtilde take note. |
@Mechtilde can you, Kyle Guinn, and I maybe collaborate on a single pull request that would support package creation? |
FYI the makefile patch mentioned here is largely PR #10, plus or minus some things, but the basic purpose was to make it easier to create a distro package. I think we deemed it too extensive of a change, so I've been trying to get it pulled in in smaller pieces, which has kind of stalled lately. I can restart that effort. |
Hello,
yes I'm willing to help as far as I can.
I opened also a bugreport
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1040171 and asking the
former maintainer for help.
I had problems to adapt the Makefiles for Debian packages
Regards
Am 30.06.23 um 22:12 schrieb meta-ed:
… @Mechtilde can you, Kyle Guinn, and I maybe collaborate on a single pull request that would support package creation?
--
Mechtilde Stehmann
## Debian Developer
## PGP encryption welcome
## F0E3 7F3D C87A 4998 2899 39E7 F287 7BBA 141A AD7F
|
I'm not too familiar with Debian's packaging procedures, but I'm browsing https://sources.debian.org/src/noweb/2.12-1/debian/patches/ and can comment on what's been done since that release. I think all three of these patches are no longer needed:
|
@turboencabulator To your point about portability: |
Hi, I still have the indentation problem with noweb 2.13, built from git on FreeBSD 13, with TeXLive 2023.
And here is some information on TeXLive:
I assume nobody else has a problem with TeXLive 2023? |
I'm not familiar with FreeBSD's git packaging; can you confirm that this includes the commit that "fixed" this issue? |
The FreeBSD package I'm using only contains texlive. Noweb 2.13 I've built myself from the git source, so I assume it contains the fix. |
Problem solved, sorry to have taken everyone's time. texlive was finding the 2.12 version of noweb.sty, not the 2.13 version. |
See also NixOS/nixpkgs#269579 |
Test file t.nw (same as
examples/test.nw
):Result is in t.pdf, which shows none of the expected indenting in codeblock
<<three>>
.The problem doesn't seem to be with
pdflatex
since a\begin{verbatim}
block retains indents.The text was updated successfully, but these errors were encountered: