-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support service account auth for Cloud Healthcare API integration #125
Comments
Yes, the best solution would be to have an OAuth client in Weasis. This would facilitate integration with the Cloud Healthcare API without the need for a special plugin. |
An OAuth2 client has been integrated in Weasis and allows access to a server with OAuth2 authentication. Here is a snapshot build for testing. For the moment there are 2 templates that help to generate all the configuration: Google Cloud Healthcare and Keycloack. @dzelemba Could the Client ID and Secret be distributed publicly? The one in the Weasis plugin: 952621265781-q7lsqhhths8jp5k124nqj7qo1la92ps5.apps.googleusercontent.com I still need to finalize the OIDC implementation to launch Weasis from a website with authentication. |
Nice! This looks great. Ya we were able to distribute it because it's a downloadable client side application and having user's create their own client IDs was too difficult. You just have to be aware than anyone can grab those secrets and use them in their own application, so you should monitor usage to detect potential abuse. |
Is your feature request related to a problem? Please describe.
When following the instructions at https://nroduit.github.io/en/basics/customize/integration/#google-cloud-healthcare-api, you have to pass a static authorization token that expires after 1hr.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Instead it'd be great to either
Note that implementing the first option is probably much simpler.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
https://github.com/GoogleCloudPlatform/weasis-chcapi-extension provides an implementation of option 2 above, but isn't compatible with the latest version of Weasis
Additional context
Add any other context or screenshots about the feature request here.
Thanks for considering this! If there isn't enough bandwidth to tackle this issue, an understanding of whether this would be a welcome FR and if so, some quick pointers would be great.
The text was updated successfully, but these errors were encountered: