Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Softlock during fight #54

Closed
CondoSlime opened this issue Aug 11, 2018 · 6 comments
Closed

Bug: Softlock during fight #54

CondoSlime opened this issue Aug 11, 2018 · 6 comments
Labels

Comments

@CondoSlime
Copy link

CondoSlime commented Aug 11, 2018

Game version
0.2.2

Browser
Chrome 68

Description
No option appeared for fighting a pest during a gang encounter https://i.imgur.com/7XHwG9j.png I have no idea what caused it. I was playing this session for an hour or 2 already and nothing out of the ordinary happened.

Oh also. after reloading and resuming I found a tattered shirt which made me over encumbered. I tried to get rid of it but pressing discard does nothing.

@nroutasuo nroutasuo added the bug label Aug 12, 2018
@nroutasuo
Copy link
Owner

I see this bug now and then but also haven't figured out real reproduction steps for it yet. I'll keep looking but if you figure out any more details about when it happens and when it doesn't I'd be really curious to hear.

I'll make a separate ticket for discard not working.

@CondoSlime
Copy link
Author

Well. I did notice that the softlock never happens on the first fight and also doesn not seem to happen often during raids if at all.

@praxiq
Copy link

praxiq commented Aug 15, 2018

Well. I did notice that the softlock never happens on the first fight

In the screenshot attached to the original post, it happens on the first fight. (it says "FIGHT 1/3"). Just happened to me too. :)

@praxiq
Copy link

praxiq commented Aug 15, 2018

Next time you get this glitch, use the devtools to inspect where the buttons are supposed to be. It looks like some sort of loop or recursion glitch. Here's an excerpt...

<div class="buttonbox" id="fight-buttons-main" data-visible="true" style="display: block;">
  <div class="callout-container" style="display: inline-block;">
     <div class="callout-container" style="display: inline-block;">
        <div class="callout-container" style="display: inline-block;">
           <div class="callout-container" style="display: inline-block;">
             <div class="callout-container" style="display: inline-block;">
<!-- ...snip another 20-30 levels deep... -->
                 <div class="callout-container" style="display: inline-block;">
                    <div class="callout-container" style="display: inline-block;">
                       <div class="callout-container" style="display: inline-block;">
                          <div class="container-btn-action">
                             <button id="out-action-fight-confirm" class="action click-bound" action="fight" data-hascooldown="false" data-visible="true" style="display: inline-block;">
                              Fight
                              <div class="cooldown-action" style="display: none; width: 100%;"></div>
                              <div class="cooldown-duration" style="display: inherit;"></div>
                             </button>
                             <div class="cooldown-reqs" style="display: none; width: 100%;"></div>
                          </div>
                       </div>
                    </div>
                 </div>
<!-- ...snip... -->
              </div>
           </div>
        </div>
     </div>
  </div>
</div>

Note that some of the intermediate layers I cut out actually say display:none instead of display:inline-block. Also, there's a similar but different (and even more complicated) cascade for the other button.

@nroutasuo
Copy link
Owner

@praxiq That's a very good hint actually and points at something I changed recently, thanks!

@nroutasuo
Copy link
Owner

I think I've finally fixed this one, fix will be in the next update. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants