Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I use external GitHub actions within Nx workflow #9

Closed
andersonba opened this issue Apr 29, 2022 · 4 comments
Closed

How do I use external GitHub actions within Nx workflow #9

andersonba opened this issue Apr 29, 2022 · 4 comments

Comments

@andersonba
Copy link

Example: I would like to "plug" the Coveralls Github Action at the end of Nx workflow, after running the tests with the coverage flag.
What should I do?

In Github Actions docs, they suggest uploading the artifacts for sharing between jobs, but it's also an action 🤷‍♂️
Should you guys break the workflow into actions to cover these complex needs?
Thanks!

@JamesHenry
Copy link
Collaborator

JamesHenry commented May 2, 2022

Hi @andersonba, just like with your other issue regarding environment variables, the update I have made to the README explains a bit more about the intention of this project and its limitations:
https://github.com/nrwl/ci#disclaimer-github-workflow-limitations

It is not possible to pass custom actions to a reusable workflow on Github.

In your case the best course of action is take the workflow config we have set up for you and use it (and customize it) directly within your own config.

Best of luck!

@domvanrob
Copy link

@andersonba I was wondering whether you ended up with a solution for using both DTE and uploading your coverage. I've got a similar situation and although the CI runs great, I can't seem to figure out how to go about uploading the coverage report.

@andersonba
Copy link
Author

Hi @robbievandam

So, as @JamesHenry said, this project has limitations and for that reason, I ended up following your suggestion: I took the workflow config to our repo, customizing it.

About the coverage reports syncing, we have steps to download the assets from our storage provider, then, merge them with lcov-result-merger, also, uploading back to the storage (main branch only), in the meantime, we call the Coveralls action.

There should probably be a better solution, but at that point, this was the output that ended up solving the problem. If you have another suggestion, I'd be grateful to hear it.

@domvanrob
Copy link

@andersonba thx for the quick response.

Some kind of integration with the upload-artifact / download-artifact would probably do the job for most cases. But don’t quote me on that because this is new terrain for me.

For now I’ll just use my old setup which is already benefiting from increased performance due to Nx Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants