Skip to content

Commit

Permalink
fix(misc): filter shared libraries by import name in module federatio…
Browse files Browse the repository at this point in the history
…n helpers (#15980)
  • Loading branch information
leosvelperez committed Mar 31, 2023
1 parent a404595 commit 5c33797
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/angular/src/utils/mf/utils.ts
Expand Up @@ -60,7 +60,7 @@ export async function getModuleFederationConfig(

if (mfConfig.shared) {
dependencies.workspaceLibraries = dependencies.workspaceLibraries.filter(
(lib) => mfConfig.shared(lib.name, {})
(lib) => mfConfig.shared(lib.importKey, {})
);
dependencies.npmPackages = dependencies.npmPackages.filter((pkg) =>
mfConfig.shared(pkg, {})
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/module-federation/utils.ts
Expand Up @@ -40,7 +40,7 @@ export async function getModuleFederationConfig(

if (mfConfig.shared) {
dependencies.workspaceLibraries = dependencies.workspaceLibraries.filter(
(lib) => mfConfig.shared(lib.name, {})
(lib) => mfConfig.shared(lib.importKey, {})
);
dependencies.npmPackages = dependencies.npmPackages.filter((pkg) =>
mfConfig.shared(pkg, {})
Expand Down

0 comments on commit 5c33797

Please sign in to comment.