fix(misc): filter shared libraries by import name in module federation helpers

[leosvelperez]

Current Behavior

The initial shared filter pass for workspace libraries uses the project name (e.g. lib1), while the second pass uses the import name (e.g. @my-org/lib1). This inconsistency causes the shared function logic to either be right for the first pass or the second, unless folks consider both possible names.

Expected Behavior

The shared function should receive a consistent library name for its execution.

We're sticking with the import name because it's what's used by webpack Module Federation and was the original behavior before the first pass was added where the project name was wrongly used.

Related Issue(s)

Fixes #15975

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
nx-dev	⬜️ Ignored (Inspect)			Mar 30, 2023 at 2:06PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9c6795e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=0cd03005c3f112fa0f0587ca728ef55a75e1a889 --head=9c6795e9f653f0481ada0008f04fa31db639b68c --parallel=1
• nx affected --target=test --base=0cd03005c3f112fa0f0587ca728ef55a75e1a889 --head=9c6795e9f653f0481ada0008f04fa31db639b68c --parallel=1
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=build --base=0cd03005c3f112fa0f0587ca728ef55a75e1a889 --head=9c6795e9f653f0481ada0008f04fa31db639b68c --parallel=3
• nx affected --target=lint --base=0cd03005c3f112fa0f0587ca728ef55a75e1a889 --head=9c6795e9f653f0481ada0008f04fa31db639b68c --parallel=3
• nx-cloud record -- nx format:check --base=0cd03005c3f112fa0f0587ca728ef55a75e1a889 --head=9c6795e9f653f0481ada0008f04fa31db639b68c
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[barrymichaeldoyle]

Looking forward to seeing this merged 👍 Was worried we wouldn't be able to update nx, but this looks like it solves it!

[barrymichaeldoyle]

Hmmm, it still doesn't work in 15.9.2 😞

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.