Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): eagerly load default packages #10207

Merged
merged 1 commit into from
May 9, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 9, 2022

Current Behavior

Certain packages may be loaded in the polyfills.ts, which need to be loaded eagerly.

Expected Behavior

We can help out with some of these packages, e.g. any official Angular packages.

Related Issue(s)

Fixes #10182

@Coly010 Coly010 requested a review from leosvelperez May 9, 2022 09:31
@Coly010 Coly010 self-assigned this May 9, 2022
@vercel
Copy link

vercel bot commented May 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 9, 2022 at 9:34AM (UTC)

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Coly010 Coly010 merged commit b513271 into nrwl:master May 9, 2022
@Coly010 Coly010 deleted the angular/default-eager-packages branch May 9, 2022 10:28
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a Kendo Dropdown breaks Module Federation with @angular/localize error
2 participants