Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] after latest release, my MFEs broke. path has changed for imports #11030

Closed
Coly010 opened this issue Jul 6, 2022 · 6 comments
Closed
Labels

Comments

@Coly010
Copy link
Contributor

Coly010 commented Jul 6, 2022

BTW after some recent upgrades, my MFEs broke. Looks like the path has changed from @nrwl/angular/mfe to @nrwl/angular/mf

image

image

Originally posted by @benpsnyder in #10887 (comment)

@Coly010
Copy link
Contributor Author

Coly010 commented Jul 6, 2022

@benpsnyder In what manner did you upgrade Nx? There were migrations that should have run that would have automatically fixed these paths for you.

Did you upgrade nx using nx migrate latest?

@Coly010 Coly010 added blocked: more info needed scope: angular Issues related to Angular support in Nx labels Jul 6, 2022
@benpsnyder
Copy link
Contributor

@Coly010 on this one ... I might have upgraded early to next while you guys were pushing betas for 14.4.x ... but I always am careful to run migrations, and when in doubt, I re-run them like so: nx migrate @nrwl/workspace@14.4.2 --from="@nrwl/workspace@14.0.0"

Sorry I know this isn't too helpful as it's not specific, but I am just letting you know that I usually don't skip the migrations! :)

@leosvelperez
Copy link
Member

@benpsnyder it turns out the migration for this is targeting 14.5.0-beta.0 but the change was released in 14.4.0. Because of that, even though the migration is available in the published package, the migrator tool doesn't pick it up because it's targeting a greater version.

Unfortunately, there's little we can do at this point to fix the existing versions (>=14.4.0 <14.5.0-beta.0) and folks that have already migrated to those versions will need to either adjust their source code manually or wait for 14.5.0 to upgrade. Pushing a change to amend the target version to 14.4.0 can only be released in a version greater than that, so, it won't solve the problem in those versions.

Because of the above, you can either:

  • Adjust your code manually to handle the changes
  • Wait for 14.5.0 to migrate to it and get the automatic migration (don't migrate to 14.5.0-beta.0, there's currently an issue with the migration that's being fixed and should be released in a later version)

@benpsnyder
Copy link
Contributor

Lovely, thorough reply. Thank you!

@leosvelperez
Copy link
Member

I'm going to close this issue since there's nothing we can do to fix the already published versions. For anyone coming to this, please wait for the 14.5.0 release which will include the automatic migration.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants