Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): explicitly stop all agents on failure #11123

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Jul 13, 2022

Current Behavior

We don't explicitly start CI runs on our CI. If an error happens before the distributed run was initiated, the agents will keep on spinning until they timeout (60min).

Expected Behavior

Agents should be killed immediately when CI run fails

Related Issue(s)

Issue discovered by @rarmatei on #11113

Fixes #

@meeroslav meeroslav self-assigned this Jul 13, 2022
@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jul 13, 2022 at 10:08AM (UTC)

@meeroslav meeroslav enabled auto-merge (squash) July 13, 2022 10:10
@meeroslav meeroslav merged commit 8ab6ad4 into nrwl:master Jul 13, 2022
@meeroslav meeroslav deleted the fix/ci-run branch November 8, 2022 15:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant