Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vanilla-extract styling #12771

Closed
lwhiteley opened this issue Oct 23, 2022 · 7 comments
Closed

Support vanilla-extract styling #12771

lwhiteley opened this issue Oct 23, 2022 · 7 comments
Labels
outdated scope: react Issues related to React support for Nx stale type: feature

Comments

@lwhiteley
Copy link

lwhiteley commented Oct 23, 2022

Description

Add native nx support for vanilla-extract styling

Motivation

Not sure what the ideology behind choosing which css libraries are used as options in nx or what criteria they must meet to be suppported natively.

Ive been playing around with vanilla-extract. I did a POC with it and nx and so far seems like a simple cohesion.

However, the custom webpack config is a bit hacky and could be improved by either supporting it natively or having a nicer way to add custom css webpack configs

Suggested Implementation

  • integration with generators
  • react template (components, apps)
  • offered as a styling option when creating an nx workspace
  • similar to all other alternatives for react styling options
  • storybook?

useful links:

@FrozenPandaz FrozenPandaz added the scope: react Issues related to React support for Nx label Oct 26, 2022
@FrozenPandaz
Copy link
Collaborator

Hm, sounds interesting.

Ultimately, we can't support every method of styling though. Would someone be interested in maintaining a plugin for vanilla-extract?

@sebastiandg7
Copy link
Contributor

sebastiandg7 commented Nov 25, 2022

@FrozenPandaz volunteer here! I was thinking just about contributing to the official plugins to support vanilla-extract. Yet, how could it be approached with a separate plugin without having to change the build executor for an app or creating a custom webpack/rollup config file (why the plugin then)?

@asherccohen
Copy link

asherccohen commented Jan 13, 2023

This would be great.

Any suggestion how to fix JEST not generating the styles?The suggested transformer is not working.

@asherccohen
Copy link

Is there interest in building something around VE?
At least giving indications of how we can get JEST to work would be great, I'm blocked with an important PR since all my tests are broken.

@asherccohen
Copy link

See #12653

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: react Issues related to React support for Nx stale type: feature
Projects
None yet
Development

No branches or pull requests

4 participants