Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): do not rename dts file since it is already done #14218

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

arturovt
Copy link
Contributor

@arturovt arturovt commented Jan 8, 2023

This is a follow up of this PR: #11032.

The fileName.replace is already being done within the code previously in the else block.

Closes #14216

@vercel
Copy link

vercel bot commented Jan 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 8, 2023 at 11:11AM (UTC)

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

LGTM! 🎉

@leosvelperez leosvelperez merged commit fb749ae into nrwl:master Jan 12, 2023
@arturovt arturovt deleted the fix/14216 branch January 12, 2023 16:11
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/angular:package does not fully emit dts files
2 participants