feat(js): update @swc/core and @swc/helpers packages #16372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysoo
requested review from
mandarini,
ndcunningham,
nartc and
xiongemi
as code owners
jaysoo
force-pushed
the
feat/update-swc-helper-package
branch
from
b5c1d8c
to
a0e27ab
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
FrozenPandaz
requested changes
Apr 18, 2023
jaysoo
force-pushed
the
feat/update-swc-helper-package
branch
2 times, most recently
from
a0e27ab
to
46f825a
Compare
mandarini
approved these changes
Apr 18, 2023
ndcunningham
approved these changes
Apr 18, 2023
jaysoo
force-pushed
the
feat/update-swc-helper-package
branch
from
d5cce4a
to
ea91cb3
Compare
FrozenPandaz
approved these changes
Apr 18, 2023
| @@ -71,11 +72,12 @@ async function addLinting(host: Tree, options: NormalizedSchema) { | |||
| { | |||
| ...extraEslintDependencies.devDependencies, | |||
| ...(options.compiler === 'swc' | |||
| ? { '@swc/core': swcCoreVersion, 'swc-loader': swcLoaderVersion } | |||
| ? { 'swc-loader': swcLoaderVersion } | |||
There was a problem hiding this comment.
Followup: I guess this is not part of addSwcDependencies?
Let's add another function to the @nx/js utils.
| @@ -1,7 +1,6 @@ | |||
| export const nxVersion = require('../../package.json').version; | |||
|
|
|||
| export const swcLoaderVersion = '0.1.15'; | |||
| export const swcHelpersVersion = '~0.4.11'; | |||
| export const tsLibVersion = '^2.3.0'; | |||
There was a problem hiding this comment.
Followup: We should also use the util in @nx/js for adding tslib.
But that's not a part of the scope for this PR so let's do it separately.
jaysoo
force-pushed
the
feat/update-swc-helper-package
branch
2 times, most recently
from
3aec57d
to
47f403b
Compare
jaysoo
force-pushed
the
feat/update-swc-helper-package
branch
from
47f403b
to
9e7c50e
Compare
peppoasap
pushed a commit
to peppoasap/nx
that referenced
this pull request
Apr 18, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates/migrates
@swc/core,@swc/cli, and@swc/helperspackages to keep them aligned.We previously mixed
^and~version ranges, which lead to some problems when@swc/corewas updated to a version incompatible with the resolved@swc/helperspackage. Now they are all on~range to mitigate these issues.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #