feat(node): replace usages of @nrwl with @nx #16379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenPandaz
requested review from
meeroslav,
JamesHenry,
nartc,
ndcunningham and
jaysoo
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
reviewed
Apr 18, 2023
|
|
||
| export async function applicationGenerator(tree: Tree, schema: Schema) { |
There was a problem hiding this comment.
I think we either remove this or reuse it in @nrwl/node:app when choosing express. Right now it is duplicated.
Out of scope for this PR, but should do a follow-up.
There was a problem hiding this comment.
I think we should reuse it.
I think @nx/node can do the framework.. but it would proxy to @nx/express (which is the real one).
I believe it's similar for @nx/node:app --framework nest right?
jaysoo
approved these changes
Apr 18, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Node packages generate
@nrwl/Expected Behavior
Node packages generate
@nx/Related Issue(s)
Fixes #