Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): use babel-loader when using styled-jsx with rspack #16443

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 20, 2023

styled-jsx needs babel in order to transpile <style jsx>{...}</style> syntax, otherwise the app will not render (you can get error because the react child is an unsupported object).

This PR fixes the setup to bring in babel-loader, which corrects the build but will be slower. A warning is logged to the user.
Screenshot 2023-04-20 at 2 53 58 PM

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 20, 2023 6:53pm

@jaysoo jaysoo marked this pull request as ready for review April 20, 2023 18:54
@jaysoo jaysoo merged commit 0a6d376 into nrwl:master Apr 20, 2023
@jaysoo jaysoo deleted the fix/rspack-styled-jsx branch April 20, 2023 19:35
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants