fix(testing): ensure e2e cypress can use 4200 port in the test #16646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
barbados-clemens
approved these changes
Apr 28, 2023
Comment on lines
+146
to
+149
| it('should run e2e in parallel', async () => { | ||
| // ensure ports are free before running tests | ||
| await killPort(4200); | ||
|
|
There was a problem hiding this comment.
interesting, because the whole point of this feature is that it can handle ports already taken, I guess makes sense to have a known clean slate, but test ideally should not have been failing from that.
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 28, 2023
This was referenced Apr 29, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In some cases, port 4200 remains occupied (probably some test does not clean its resources), in which case this test fails as it explicitly expects 4200 to be free.
Expected Behavior
Ensure port 4200 is freed before we start the test
Related Issue(s)
Fixes #