Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix external npm packages for rollup #16713

Merged
merged 1 commit into from
May 3, 2023

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented May 3, 2023

Current Behavior

  • when developers want to include a package in the code explicitly, currently there is no way. when that package is not specified from external, it will still treat it as external and not include it in the source code.

Expected Behavior

  • when external is not specified, it will include the package in the code
  • add option all and none for external

Related Issue(s)

Fixes #10405

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 2:15am

- when external is not specify, will include package in the code
- add option all and none for external
@github-actions
Copy link

github-actions bot commented May 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
@xiongemi xiongemi deleted the bugfix/fix-rollup-external branch June 8, 2023 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to bundle dependency with @nrwl/web:rollup
2 participants