fix(testing): merge builder globals with jest.config.js globals #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR looks good, but I think a unit test failed. |
jdpearce
force-pushed
the
1059-jest-globals
branch
2 times, most recently
from
bacbe76
to
589d3f6
Compare
…r than override them completely Resolves nrwl#1059
jdpearce
force-pushed
the
1059-jest-globals
branch
from
589d3f6
to
72c3a8f
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rather than override them completely.
Resolves #1059
This also removes the
diagnostics.warnOnlyflag from the builder globals, allowing the user to set it themselves. This may cause previously passing tests to fail, but only because they have errors.