fix(core): handle symlinks on debian for watch events #18636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cammisuli
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Cammisuli
force-pushed
the
fix_debian_watcher_symlinks
branch
from
9bd5ed3
to
d85ed26
Compare
Cammisuli
force-pushed
the
fix_debian_watcher_symlinks
branch
from
d85ed26
to
3fcd033
Compare
|
We will also need this for arch apparently, but we can do it as a followup |
FrozenPandaz
approved these changes
Aug 16, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 16, 2023
(cherry picked from commit cf0b2fd)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running a yarn/pnpm workspace dependant libraries are symlinked in node_modules. On debian, when watch events are triggered from these dependent libraries, the symlink path is used (ie,
workspace/pkgs/a/node_modules/pkgs/b/lib.ts) instead of their real path (workspace/pkgs/b/lib.ts). Because we implicity ignore all events from node_modules, these events never get pass the filter and we are never notified.Expected Behavior
Paths are canonicalize to their real paths (only on debian)
Related Issue(s)
Fixes #18218