Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): set "watch: false" on module federation serve-static options #19052

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 7, 2023

file-server watches for changes by default, which defeats the purpose of static serve

Current Behavior

Static remotes are also reloaded on changes.

Expected Behavior

Static remotes should not reload on changes.

Related Issue(s)

Fixes #

file-server watches for changes by default, which defeats the purpose of
static serve
@jaysoo jaysoo requested a review from a team as a code owner September 7, 2023 14:58
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2023 2:58pm

@jaysoo jaysoo merged commit 305b443 into nrwl:master Sep 7, 2023
3 checks passed
@jaysoo jaysoo deleted the fix/react-mf-static-remote-gen branch September 7, 2023 16:41
FrozenPandaz pushed a commit that referenced this pull request Sep 7, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants