Missing emitDecoratorMetadata=true for NestJS projects when using Angular workspace

[da-mkay]

Expected Behavior

When adding a new NestJS application to an Angular workspace using the application schematic from the @nrwl/nest package, the application should work out of the box.

Current Behavior

The created app does not work properly. First, it looks like everything is working fine. But as soon as typical NestJS decorators are used, unexpected behaviour can happen. For example, when adding the ValidationPipe using @UsePipes(...) no validation is performed at all. This is because the tsconfig.json files does not contain emitDecoratorMetadata=true.

Failure Information (for bugs)

When using an Angular workspace - no NX workspace - emitDecoratorMetadata is not set by default since Angular 8.1 (see #1801). But emitDecoratorMetadata=true is required for NestJS applications to run properly, as described above.

Either the workspace-schematic or the NestJS application schematic should update the tsconfig accordingly.

I could provide a PR if you tell where I should add this (workspace or NestJS application schematic) and which tsconfig should be updated: in my opinion the app's tsconfig should be updated, not the global one in the root folder.

Steps to Reproduce

1. Create a workspace with Angular 8.1.
2. Create NestJS application with schematic.
3. Add some ValidationPipe with @UsePipes
4. Check if validation is really performed.

[FrozenPandaz]

The @nrwl/nest:application schematic can be updated to modify the tsconfig.json using the updateJsonInTree method:

nx/packages/nest/src/schematics/application/application.ts

Line 73 in 44c8d17

addAppFiles(options)

We would be glad to accept PRs to address this!

[mehrad-rafigh]

I think we can close this issue @FrozenPandaz

[Cammisuli]

resolved in #2023

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.