-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): warn when falling back to angular cli for misc commands #12401
feat(core): warn when falling back to angular cli for misc commands #12401
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
152218d
to
ab8650d
Compare
packages/nx/bin/init-local.ts
Outdated
@@ -143,6 +143,20 @@ function handleAngularCLIFallbacks(workspace: WorkspaceTypeAndRoot) { | |||
Instead, you could try an Nx Editor Plugin for a visual tool to run Nx commands. If you're using VSCode, you can use the Nx Console plugin, or if you're using WebStorm, you could use one of the available community plugins. | |||
For more information, see https://nx.dev/using-nx/console`); | |||
} else { | |||
const [, , command, project, ...args] = process.argv; | |||
logger.warn( | |||
`${NX_PREFIX} Falling back to \`ng ${command} ${project} ${args.join( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably break ng completion
?
For now can we just remove deploy
from this list without any warning for fallback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If worried about ng completion
in particular, we could hide the warning for it specifically?
ab8650d
to
ab217b4
Compare
(cherry picked from commit 74e898d)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #