Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): find imports after template literals with vars #13922

Merged
merged 1 commit into from
Dec 28, 2022
Merged

fix(core): find imports after template literals with vars #13922

merged 1 commit into from
Dec 28, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 20, 2022

Current Behavior

If you have a template literal in your code all the code between the closing backtick of your template literal, to either the end of the file or the next template literal, will be treated as a SyntaxKind.TemplateHead and therefore not scanned for imports.

Expected Behavior

All import statements in a file, regardless of the other expressions in that file, should be found.

Related Issue(s)

No issue created.

@vercel
Copy link

vercel bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 27, 2022 at 4:02PM (UTC)

@spalger

This comment was marked as outdated.

@AgentEnder AgentEnder merged commit ba7eb9d into nrwl:master Dec 28, 2022
AgentEnder pushed a commit to AgentEnder/nx that referenced this pull request Dec 29, 2022
@spalger spalger deleted the fix/import-after-template branch December 30, 2022 02:27
@spalger
Copy link
Contributor Author

spalger commented Dec 30, 2022

Thanks @AgentEnder, would you mind taking a look at #13921 too?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants