Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo): address deprecation warning seen upon using @nrwl/expo:start #14095

Merged

Conversation

dankreiger
Copy link
Contributor

@dankreiger dankreiger commented Jan 2, 2023

Note

The same fix was applied a while ago in @nrwl/react-native: #7772

Current Behavior

Upon running:

# uses `@nrwl/expo:start` executor
npx nx start my-app

I see:

Packager is ready at http://localhost:8081
(node:33501) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)

deprecation

Expected Behavior

Upon replacing the function.

Screenshot 2023-01-02 at 20 28 14

Related Issue(s)

#14094

Fixes #
#14094

@vercel
Copy link

vercel bot commented Jan 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 2, 2023 at 8:08PM (UTC)

@dankreiger dankreiger changed the title fix(expo): address deprecation warning see upon running expo start fix(expo): address deprecation warning seen upon using @nrwl/expo:start Jan 2, 2023
@AgentEnder AgentEnder merged commit 217d6e3 into nrwl:master Jan 2, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants